From: Sascha Hauer <s.hauer@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] nand: denali: use correct interrupts in read_page
Date: Mon, 26 Sep 2016 08:03:46 +0200 [thread overview]
Message-ID: <20160926060346.qyvberbkwmovl3fn@pengutronix.de> (raw)
In-Reply-To: <20160922144639.28305-1-s.trumtrar@pengutronix.de>
On Thu, Sep 22, 2016 at 04:46:37PM +0200, Steffen Trumtrar wrote:
> The interrupt mask is incorrect in case of HW error correction.
> The driver will time out waiting for the wrong interrupts.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> drivers/mtd/nand/nand_denali.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mtd/nand/nand_denali.c b/drivers/mtd/nand/nand_denali.c
> index bf9a05d85264..ceb5a8b87e42 100644
> --- a/drivers/mtd/nand/nand_denali.c
> +++ b/drivers/mtd/nand/nand_denali.c
> @@ -1102,8 +1102,9 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip,
> size_t size = denali->mtd.writesize + denali->mtd.oobsize;
>
> uint32_t irq_status;
> - uint32_t irq_mask = INTR_STATUS__ECC_TRANSACTION_DONE |
> - INTR_STATUS__ECC_ERR;
> + uint32_t irq_mask = denali->have_hw_ecc_fixup ?
> + (INTR_STATUS__DMA_CMD_COMP) :
> + (INTR_STATUS__ECC_TRANSACTION_DONE | INTR_STATUS__ECC_ERR);
> bool check_erased_page = false;
>
> if (page != denali->page) {
> --
> 2.9.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-09-26 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:46 Steffen Trumtrar
2016-09-22 14:46 ` [PATCH 2/3] nand: denali: use is_timeout in while loop Steffen Trumtrar
2016-09-22 14:46 ` [PATCH 3/3] nand: denali: get rid of compile-time debug information Steffen Trumtrar
2016-09-26 6:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926060346.qyvberbkwmovl3fn@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox