From: Giorgio Dal Molin <iw3gtf@arcor.de>
To: barebox@lists.infradead.org
Cc: Giorgio Dal Molin <iw3gtf@arcor.de>
Subject: [PATCH 0/2 (try 2)] mtd: ubi: implement the new command 'ubirename'
Date: Mon, 26 Sep 2016 12:52:31 +0200 [thread overview]
Message-ID: <20160926105233.26387-1-iw3gtf@arcor.de> (raw)
In-Reply-To: <20160926061912.elzmjbs4mdv5ztrb@pengutronix.de>
Here a new set of patches implementing the command 'ubirename'.
They are based on a patch serie from Sascha that restructures a bit
the barebox UBI APIs. In particular it is now easier to find the ubi
volume ids from the command code. Moreover the command code uses now
api functions to do the rename.
This new set also fixes some minor cosmetic details noted by Sascha and
a real problem found in the function 'get_vol_id()': it was missing
a call to 'ubi_close_volume(desc)' hence leaving ubi volumes busy.
A simple test that showed the problem was:
bb> ubimkvol /dev/nand0.ubi_volumes.ubi vol_A 10MiB
bb> ubirename /dev/nand0.ubi_volumes.ubi vol_A vol_B
bb> ubirmvol /dev/nand0.ubi_volumes.ubi vol_B
The last command, ubirmvol, failed because 'vol_B' appeared to be still
busy after the rename (vol->readers==1).
Giorgio Dal Molin (2):
mtd: ubi: add API call to rename volumes.
mtd: ubi: commands: added the new command 'ubirename'.
commands/ubi.c | 72 +++++++++++++++++++++
drivers/mtd/ubi/barebox.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++
drivers/mtd/ubi/vmt.c | 3 +
include/linux/mtd/ubi.h | 1 +
4 files changed, 232 insertions(+)
--
2.10.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-09-26 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 8:04 [PATCH 0/2] added support for renaming UBI volumes Giorgio Dal Molin
2016-09-21 8:04 ` [PATCH 1/2] mtd: UBI: add support (ioctl) for renaming ubi volumes Giorgio Dal Molin
2016-09-21 8:04 ` [PATCH 2/2] commands: ubi: added the new command 'ubirename' to rename " Giorgio Dal Molin
2016-09-22 8:04 ` Sascha Hauer
2016-09-23 9:07 ` [PATCH 0/2] mtd: ubi: implement the new command 'ubirename' Giorgio Dal Molin
2016-09-23 9:07 ` [PATCH 1/2] mtd: ubi: add API call to rename volumes Giorgio Dal Molin
2016-09-23 9:07 ` [PATCH 2/2] mtd: ubi: commands: added the new command 'ubirename' Giorgio Dal Molin
2016-09-26 6:19 ` Sascha Hauer
2016-09-26 10:52 ` Giorgio Dal Molin [this message]
2016-09-27 6:21 ` [PATCH 0/2 (try 2)] mtd: ubi: implement " Sascha Hauer
2016-09-26 10:52 ` [PATCH 1/2] mtd: ubi: add API call to rename volumes Giorgio Dal Molin
2016-09-26 10:52 ` [PATCH 2/2] mtd: ubi: commands: added the new command 'ubirename' Giorgio Dal Molin
2016-09-23 10:11 ` Aw: Re: [PATCH 2/2] commands: ubi: added the new command 'ubirename' to rename ubi volumes iw3gtf
2016-09-27 6:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926105233.26387-1-iw3gtf@arcor.de \
--to=iw3gtf@arcor.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox