mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/3] watchdog: add designware driver
Date: Mon, 17 Oct 2016 09:48:20 +0200	[thread overview]
Message-ID: <20161017074820.225nlw6c2knd4j7r@pengutronix.de> (raw)
In-Reply-To: <20161014092715.4257-2-s.trumtrar@pengutronix.de>

On Fri, Oct 14, 2016 at 11:27:14AM +0200, Steffen Trumtrar wrote:
> Port the linux v4.8-rc1 Synopsys DesignWare watchdog driver to barebox.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> Changes since v1:
>   - change usages of pr_warn in favor of dev_warn
> 
>  drivers/watchdog/Kconfig  |   6 ++
>  drivers/watchdog/Makefile |   1 +
>  drivers/watchdog/dw_wdt.c | 193 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 200 insertions(+)
>  create mode 100644 drivers/watchdog/dw_wdt.c
> 

(...)

> +struct dw_wdt {
> +	void __iomem		*regs;
> +	struct clk		*clk;
> +	struct restart_handler	restart;
> +	struct watchdog		wdd;
> +	struct reset_control	*rst;
> +};
> +

(...)

> +static int dw_wdt_stop(struct watchdog *wdd)
> +{
> +	struct dw_wdt *dw_wdt = to_dw_wdt(wdd);
> +
> +	if (IS_ERR(dw_wdt->rst)) {
> +		dev_warn(dw_wdt->dev, "No reset line. Will not stop.\n");
                         ^^^^^^^^^^^

Meh, I sent the wrong version :-(
Let's try again.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-10-17  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14  9:27 [PATCH v2 1/3] reset: import socfpga-reset driver from linux Steffen Trumtrar
2016-10-14  9:27 ` [PATCH v2 2/3] watchdog: add designware driver Steffen Trumtrar
2016-10-17  7:48   ` Steffen Trumtrar [this message]
2016-10-14  9:27 ` [PATCH v2 3/3] ARM: socfpga: dtsi: add dw-wdt reset lines Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161017074820.225nlw6c2knd4j7r@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox