From: Sascha Hauer <s.hauer@pengutronix.de>
To: Stefan Lengfeld <s.lengfeld@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: phycore-imx6: refactor fec nodes
Date: Wed, 7 Dec 2016 21:14:25 +0100 [thread overview]
Message-ID: <20161207201425.5qk5scdapyuuu5n5@pengutronix.de> (raw)
In-Reply-To: <1480322700-3529-1-git-send-email-s.lengfeld@phytec.de>
On Mon, Nov 28, 2016 at 09:44:58AM +0100, Stefan Lengfeld wrote:
> Refactor the common settings for device tree node 'fec' into the generic
> phycore i.MX6 device tree file. This avoid redundant settings and makes
> common fixes easier. Our kernel device tree files have the same layout.
>
> Signed-off-by: Stefan Lengfeld <s.lengfeld@phytec.de>
> ---
> arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts | 17 ++++-------------
> arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts | 17 ++++-------------
> arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts | 17 ++++-------------
> arch/arm/dts/imx6q-phytec-phycore-som-nand.dts | 17 ++++-------------
> arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi | 13 +++++++++++++
> 5 files changed, 29 insertions(+), 52 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts
> index fc153a6..bffee5f 100644
> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts
> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-emmc.dts
> @@ -29,21 +29,12 @@
> status = "okay";
> };
>
> +ðphy {
> + max-speed = <100>;
> +};
> +
> &fec {
> status = "okay";
> - phy-handle = <ðphy>;
> - phy-mode = "rgmii";
> - phy-reset-gpios = <&gpio1 14 1>;
> -
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - ethphy: ethernet-phy@3 {
> - reg = <3>;
> - max-speed = <100>;
> - };
> - };
> };
>
> &flash {
> diff --git a/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts b/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts
> index 3f2f1c7..1b66fda 100644
> --- a/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts
> +++ b/arch/arm/dts/imx6dl-phytec-phycore-som-nand.dts
> @@ -24,21 +24,12 @@
> status = "okay";
> };
>
> +ðphy {
> + max-speed = <100>;
> +};
> +
> &fec {
> status = "okay";
> - phy-handle = <ðphy>;
> - phy-mode = "rgmii";
> - phy-reset-gpios = <&gpio1 14 1>;
> -
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - ethphy: ethernet-phy@3 {
> - reg = <3>;
> - max-speed = <100>;
> - };
> - };
> };
>
> &gpmi {
> diff --git a/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts b/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts
> index 74bc09b..ecc5aa3 100644
> --- a/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts
> +++ b/arch/arm/dts/imx6q-phytec-phycore-som-emmc.dts
> @@ -28,21 +28,12 @@
> status = "okay";
> };
>
> +ðphy {
> + max-speed = <1000>;
> +};
> +
> &fec {
> status = "okay";
> - phy-handle = <ðphy>;
> - phy-mode = "rgmii";
> - phy-reset-gpios = <&gpio1 14 1>;
> -
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - ethphy: ethernet-phy@3 {
> - reg = <3>;
> - max-speed = <1000>;
> - };
> - };
> };
>
> &flash {
> diff --git a/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts b/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts
> index aa2c94a..9ad7eda 100644
> --- a/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts
> +++ b/arch/arm/dts/imx6q-phytec-phycore-som-nand.dts
> @@ -29,21 +29,12 @@
> status = "okay";
> };
>
> +ðphy {
> + max-speed = <1000>;
> +};
> +
> &fec {
> status = "okay";
> - phy-handle = <ðphy>;
> - phy-mode = "rgmii";
> - phy-reset-gpios = <&gpio1 14 1>;
> -
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - ethphy: ethernet-phy@3 {
> - reg = <3>;
> - max-speed = <1000>;
> - };
> - };
> };
>
> &flash {
> diff --git a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> index d446a5e..9649817 100644
> --- a/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -10,6 +10,7 @@
> */
>
> #include "imx6qdl.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> chosen {
> @@ -76,7 +77,19 @@
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> + phy-handle = <ðphy>;
> + phy-mode = "rgmii";
> + phy-reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
> status = "disabled";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy: ethernet-phy@3 {
> + reg = <3>;
> + };
> + };
> };
>
> &gpmi {
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-12-07 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 8:44 Stefan Lengfeld
2016-11-28 8:44 ` [PATCH 2/3] ARM: dts: phycore-imx6: fix missing ?xc-skew-ps settings for ethphy Stefan Lengfeld
2016-11-28 8:45 ` [PATCH 3/3] ARM: dts: phycore-imx6: remove unnecessary include Stefan Lengfeld
2016-12-07 20:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207201425.5qk5scdapyuuu5n5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.lengfeld@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox