From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, Michel Stam <m.stam@fugro.nl>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ata: pata-imx: simplify assignment of device name
Date: Wed, 11 Jan 2017 17:06:56 +0100 [thread overview]
Message-ID: <20170111160656.hx3k6a4frs32gm76@pengutronix.de> (raw)
In-Reply-To: <20170109085336.x47typrhxwajq3fg@pengutronix.de>
On Mon, Jan 09, 2017 at 09:53:36AM +0100, Sascha Hauer wrote:
> On Fri, Dec 23, 2016 at 10:50:46AM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Fri, Dec 23, 2016 at 10:45:49AM +0100, Uwe Kleine-König wrote:
> > > dev->detect = pata_imx_detect;
> >
> > BTW, another thing I noticed while reading through this driver is:
> >
> > pata_imx_detect is a wrapper around ata_port_detect. Later in
> > imx_pata_probe the function ide_port_register is called which also calls
> > ata_port_detect.
> >
> > I don't have a machine handy where I could test, but I guess
> > pata_imx_detect could be dropped. (Or alternatively ide_port_register
> > could be reworked and all callers fixed to setup a detect call.)
>
>
> ide_port_register() has:
>
> ret = ata_port_register(&ide->port);
> if (!ret)
> ata_port_detect(&ide->port);
>
> The call to ata_port_detect() goes back to:
>
> commit 9c8f73ba86884026f4bbfc6f593d73741cfebcdc
> Author: Michel Stam <m.stam@fugro.nl>
> Date: Mon Apr 7 12:01:21 2014 +0200
>
> The hunk adding ata_port_detect() is wrong as it shortcircuits the
> optional detection mechanism.
Who fixes this? /me looks at Michel who was added to Cc: :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-01-11 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 9:45 Uwe Kleine-König
2016-12-23 9:50 ` Uwe Kleine-König
2017-01-09 8:53 ` Sascha Hauer
2017-01-11 16:06 ` Uwe Kleine-König [this message]
2017-01-09 8:43 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111160656.hx3k6a4frs32gm76@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.stam@fugro.nl \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox