mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] arm: boards: phytec-som-am335x: Remove 1GB RAM type
Date: Fri, 10 Feb 2017 13:23:52 +0100	[thread overview]
Message-ID: <20170210122351.7pzykuyfz2mayjky@pengutronix.de> (raw)
In-Reply-To: <1485955486-31573-1-git-send-email-d.schultz@phytec.de>

Hi Daniel,

On Wed, Feb 01, 2017 at 02:24:46PM +0100, Daniel Schultz wrote:
> This machine was a prototype and was never shipped to customers.
> 
> Since it has no dependencies to any image, it can be removed.

This doesn't seem to be entirely true:

/opt/OSELAS.Toolchain-2014.12.0/arm-v5te-linux-gnueabi/gcc-4.9.2-glibc-2.20-binutils-2.24-kernel-3.16-sanitized/bin/arm-v5te-linux-gnueabi-ld: warning: cannot find entry symbol start_am33xx_phytec_phycore_sram_1024mb; defaulting to 0000000000000000
invalid magic
/ptx/work/dude/WORK_A/sha/backup/barebox/barebox-test/images/Makefile:77: recipe for target 'images/start_am33xx_phytec_phycore_sram_1024mb.pblx' failed
make[1]: *** [images/start_am33xx_phytec_phycore_sram_1024mb.pblx] Error 1
Makefile:491: recipe for target 'images' failed
make: *** [images] Error 2

Dropped this patch for now. You have to remove the entries in
Makefile.am335x aswell.

Sascha

> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  arch/arm/boards/phytec-som-am335x/lowlevel.c    |  1 -
>  arch/arm/boards/phytec-som-am335x/ram-timings.h | 21 ---------------------
>  2 files changed, 22 deletions(-)
> 
> diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> index 33e83c5..03c7e98 100644
> --- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
> +++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> @@ -122,7 +122,6 @@ PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_sram_128mb, am335x_phytec_phycore_s
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_sram_256mb, am335x_phytec_phycore_som_mlo, PHYCORE_MT41J128M16125IT_256MB);
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_sram_512mb, am335x_phytec_phycore_som_mlo, PHYCORE_MT41J256M16HA15EIT_512MB);
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_sram_2x512mb, am335x_phytec_phycore_som_mlo, PHYCORE_MT41J512M8125IT_2x512MB);
> -PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_sram_1024mb, am335x_phytec_phycore_som_mlo, PHYCORE_IM8G16D3FBBG15EI_1024MB);
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_r2_sram_512mb, am335x_phytec_phycore_som_mlo, PHYCORE_R2_MT41K256M16TW107IT_512MB);
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_r2_sram_256mb, am335x_phytec_phycore_som_mlo, PHYCORE_R2_MT41K128M16JT_256MB);
>  PHYTEC_ENTRY_MLO(start_am33xx_phytec_phycore_r2_sram_1024mb,  am335x_phytec_phycore_som_mlo, PHYCORE_R2_MT41K512M16HA125IT_1024MB);
> diff --git a/arch/arm/boards/phytec-som-am335x/ram-timings.h b/arch/arm/boards/phytec-som-am335x/ram-timings.h
> index 4ea654d..d1947b5 100644
> --- a/arch/arm/boards/phytec-som-am335x/ram-timings.h
> +++ b/arch/arm/boards/phytec-som-am335x/ram-timings.h
> @@ -29,7 +29,6 @@ enum {
>  	PHYCORE_MT41J64M1615IT_128MB,
>  	PHYCORE_MT41J256M16HA15EIT_512MB,
>  	PHYCORE_MT41J512M8125IT_2x512MB,
> -	PHYCORE_IM8G16D3FBBG15EI_1024MB,
>  	PHYCORE_R2_MT41K256M16TW107IT_512MB,
>  	PHYCORE_R2_MT41K128M16JT_256MB,
>  	PHYCORE_R2_MT41K512M16HA125IT_1024MB,
> @@ -162,26 +161,6 @@ struct am335x_sdram_timings physom_timings[] = {
>  		},
>  	},
>  
> -	/* 1024MB */
> -	[PHYCORE_IM8G16D3FBBG15EI_1024MB] = {
> -		.regs = {
> -			.emif_read_latency	= 0x7,
> -			.emif_tim1		= 0x0AAAE4DB,
> -			.emif_tim2		= 0x268F7FDA,
> -			.emif_tim3		= 0x501F88BF,
> -			.ocp_config		= 0x003d3d3d,
> -			.sdram_config		= 0x61C053B2,
> -			.zq_config		= 0x50074BE4,
> -			.sdram_ref_ctrl		= 0x00000C30
> -		},
> -		.data = {
> -			.rd_slave_ratio0	= 0x33,
> -			.wr_dqs_slave_ratio0	= 0x4a,
> -			.fifo_we_slave_ratio0	= 0xa4,
> -			.wr_slave_ratio0	= 0x85,
> -		},
> -	},
> -
>  	/* 256MB */
>  	[PHYCARD_NT5CB128M16BP_256MB] = {
>  		.regs = {
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2017-02-10 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 13:24 Daniel Schultz
2017-02-07  8:45 ` Sascha Hauer
2017-02-10 12:23 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210122351.7pzykuyfz2mayjky@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox