From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] fbcon: use __iowrite{32/64} to speedup the framebuffer console scrolling
Date: Fri, 10 Mar 2017 08:00:43 +0100 [thread overview]
Message-ID: <20170310070043.qsu5mcr2fmnn3oxi@pengutronix.de> (raw)
In-Reply-To: <1489055471-12836-3-git-send-email-plagnioj@jcrosoft.com>
On Thu, Mar 09, 2017 at 11:31:11AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this devide the time by 4 on x86
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/video/fbconsole.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c
> index b261f1704..b5e951e23 100644
> --- a/drivers/video/fbconsole.c
> +++ b/drivers/video/fbconsole.c
> @@ -6,6 +6,7 @@
> #include <gui/image_renderer.h>
> #include <gui/graphic_utils.h>
> #include <linux/font.h>
> +#include <linux/io.h>
>
> enum state_t {
> LIT, /* Literal input */
> @@ -202,7 +203,7 @@ static void printchar(struct fbc_priv *priv, int c)
>
> buf = gui_screen_render_buffer(priv->sc);
>
> - memcpy(buf, buf + line_height, line_height * priv->rows);
> + __iowrite64_copy(buf, buf + line_height, (line_height * priv->rows) >> 2);
Shouldn't this be >> 3?
Besides, I'm not sure using __iowrite64_copy is the right weapon here.
Maybe better port arch/x86/lib/memcpy_64.S to get an optimized memcpy?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-03-10 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 10:31 [PATCH 1/3] import linux __iowrite32/64_copy support Jean-Christophe PLAGNIOL-VILLARD
2017-03-09 10:31 ` [PATCH 2/3] x86: add __raw_read{b,w,l,q} and __raw_write{b,w,l,q} Jean-Christophe PLAGNIOL-VILLARD
2017-03-09 10:31 ` [PATCH 3/3] fbcon: use __iowrite{32/64} to speedup the framebuffer console scrolling Jean-Christophe PLAGNIOL-VILLARD
2017-03-10 7:00 ` Sascha Hauer [this message]
2017-03-10 13:58 ` Jean-Christophe PLAGNIOL-VILLARD
2017-03-10 14:30 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310070043.qsu5mcr2fmnn3oxi@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox