From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org>
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
 by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))
 id 1cmEXz-0008Mf-MX
 for barebox@lists.infradead.org; Fri, 10 Mar 2017 07:01:11 +0000
Date: Fri, 10 Mar 2017 08:00:43 +0100
From: Sascha Hauer <s.hauer@pengutronix.de>
Message-ID: <20170310070043.qsu5mcr2fmnn3oxi@pengutronix.de>
References: <1489055471-12836-1-git-send-email-plagnioj@jcrosoft.com>
 <1489055471-12836-3-git-send-email-plagnioj@jcrosoft.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1489055471-12836-3-git-send-email-plagnioj@jcrosoft.com>
List-Id: <barebox.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/barebox>,
 <mailto:barebox-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/barebox/>
List-Post: <mailto:barebox@lists.infradead.org>
List-Help: <mailto:barebox-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/barebox>,
 <mailto:barebox-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "barebox" <barebox-bounces@lists.infradead.org>
Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org
Subject: Re: [PATCH 3/3] fbcon: use __iowrite{32/64} to speedup the
 framebuffer console scrolling
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org

On Thu, Mar 09, 2017 at 11:31:11AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this devide the time by 4 on x86
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  drivers/video/fbconsole.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c
> index b261f1704..b5e951e23 100644
> --- a/drivers/video/fbconsole.c
> +++ b/drivers/video/fbconsole.c
> @@ -6,6 +6,7 @@
>  #include <gui/image_renderer.h>
>  #include <gui/graphic_utils.h>
>  #include <linux/font.h>
> +#include <linux/io.h>
>  
>  enum state_t {
>  	LIT,				/* Literal input */
> @@ -202,7 +203,7 @@ static void printchar(struct fbc_priv *priv, int c)
>  
>  		buf = gui_screen_render_buffer(priv->sc);
>  
> -		memcpy(buf, buf + line_height, line_height * priv->rows);
> +		__iowrite64_copy(buf, buf + line_height, (line_height * priv->rows) >> 2);

Shouldn't this be >> 3?

Besides, I'm not sure using __iowrite64_copy is the right weapon here.
Maybe better port arch/x86/lib/memcpy_64.S to get an optimized memcpy?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox