mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] net: phy: mdio-gpio.c: fix "no previous prototype" warning
@ 2017-03-24  3:39 Antony Pavlov
  2017-03-24  6:44 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2017-03-24  3:39 UTC (permalink / raw)
  To: barebox

The patch fixes this compiler's warning:

drivers/net/phy/mdio-gpio.c:48:24: warning: no previous prototype
        for 'mdio_gpio_of_get_info' [-Wmissing-prototypes]
 struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
                        ^

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/net/phy/mdio-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index a839f2dee..a846fb28e 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -45,7 +45,7 @@ struct mdio_gpio_info {
 	int mdc_active_low, mdio_active_low, mdo_active_low;
 };
 
-struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
+static struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
 {
 	int ret;
 	enum of_gpio_flags flags;
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: phy: mdio-gpio.c: fix "no previous prototype" warning
  2017-03-24  3:39 [PATCH] net: phy: mdio-gpio.c: fix "no previous prototype" warning Antony Pavlov
@ 2017-03-24  6:44 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2017-03-24  6:44 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox

On Fri, Mar 24, 2017 at 06:39:54AM +0300, Antony Pavlov wrote:
> The patch fixes this compiler's warning:
> 
> drivers/net/phy/mdio-gpio.c:48:24: warning: no previous prototype
>         for 'mdio_gpio_of_get_info' [-Wmissing-prototypes]
>  struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
>                         ^
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/net/phy/mdio-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
> index a839f2dee..a846fb28e 100644
> --- a/drivers/net/phy/mdio-gpio.c
> +++ b/drivers/net/phy/mdio-gpio.c
> @@ -45,7 +45,7 @@ struct mdio_gpio_info {
>  	int mdc_active_low, mdio_active_low, mdo_active_low;
>  };
>  
> -struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
> +static struct mdio_gpio_info *mdio_gpio_of_get_info(struct device_d *dev)
>  {
>  	int ret;
>  	enum of_gpio_flags flags;
> -- 
> 2.11.0
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-24  6:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24  3:39 [PATCH] net: phy: mdio-gpio.c: fix "no previous prototype" warning Antony Pavlov
2017-03-24  6:44 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox