From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck Jullien <franck.jullien@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH] openrisc: fix call to restart_handler_register_fn
Date: Tue, 4 Apr 2017 08:46:39 +0200 [thread overview]
Message-ID: <20170404064639.4bpzano7t57joqwo@pengutronix.de> (raw)
In-Reply-To: <CAJfOKBxJ0FwF0VBpeDTxe7cvgxmTW2xYHoCgXNAL+q+=9v=O6Q@mail.gmail.com>
On Wed, Mar 29, 2017 at 03:45:04PM +0200, Franck Jullien wrote:
> 2017-03-29 8:42 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Fri, Mar 24, 2017 at 08:35:22PM +0100, Franck Jullien wrote:
> >> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> >> ---
> >> arch/openrisc/cpu/cpu.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/openrisc/cpu/cpu.c b/arch/openrisc/cpu/cpu.c
> >> index d52b021..e7f9445 100644
> >> --- a/arch/openrisc/cpu/cpu.c
> >> +++ b/arch/openrisc/cpu/cpu.c
> >> @@ -41,6 +41,6 @@ static void __noreturn openrisc_restart_cpu(struct restart_handler *rst)
> >>
> >> static int restart_register_feature(void)
> >> {
> >> - restart_handler_register_fn(openrisc_restart_cpu, NULL, RESET_SCOPE_CPU);
> >> + return restart_handler_register_fn(openrisc_restart_cpu);
> >> }
> >
> > Applied, thanks. It seems I have disabled my openrisc autobuild at some
> > point. Just re-enabled it. Normally such build failures shouldn't
> > happen.
> >
>
> FYI, you can get the lastest toolchain here:
>
> https://github.com/openrisc/or1k-gcc/releases/tag/or1k-5.4.0-20170218
Thanks for noting. I just updated my toolchain to the latest one. From a
quick test it seems to work.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-04-04 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 19:35 Franck Jullien
2017-03-29 6:42 ` Sascha Hauer
2017-03-29 13:45 ` Franck Jullien
2017-04-04 6:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404064639.4bpzano7t57joqwo@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=franck.jullien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox