From: Sascha Hauer <s.hauer@pengutronix.de>
To: Stefan Lengfeld <contact@stefanchrist.eu>
Cc: barebox@lists.infradead.org, "Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: Re: [PATCH] ARM: imx: add support for Udoo Neo full
Date: Fri, 30 Jun 2017 08:35:47 +0200 [thread overview]
Message-ID: <20170630063547.cji5g7inho5efioo@pengutronix.de> (raw)
In-Reply-To: <20170627194002.GB675@sill.h.stcim.de>
On Tue, Jun 27, 2017 at 09:40:02PM +0200, Stefan Lengfeld wrote:
> Hi Uwe,
>
> Just my too cents:
>
> On Tue, Jun 27, 2017 at 09:03:17PM +0200, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > +++ b/arch/arm/boards/udoo-neo/flash-header-mx6sx-udoo-neo_full.imxcfg
> > @@ -0,0 +1,124 @@
> > +loadaddr 0x80000000
> > +soc imx6
> > +dcdofs 0x400
>
> I'm always wondering where the magic values in the flash headers are
> coming from. Whether they are copied from u-boot or another
> variant/board or completely self-made or provided by a friendly hardware
> engineer in an Excel sheet ;-) Maybe you can add a comment here or in
> the commit message. But this would be a new convention, because I have
> not seen it in other flash headers yet.
Adding this information is a good idea. In this case the values come
from:
/*
* These values are taken from:
* repository: https://github.com/UDOOboard/uboot-imx
* branch: udoo/2015.04.imx
* file: board/udoo/udoo_neo/udoo_neo_basic.cfg
*/
I was about to apply Uwes patch along with this comment, but I just
realized that the values are from udoo_neo_basic whereas the patch
seems to support the udoo_neo_full. The udoo neo full has slightly
different calibration values in the branch above, but probably they
work on both boards. Uwe, do you know which hardware we actually have
and support?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-06-30 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 19:03 Uwe Kleine-König
2017-06-27 19:40 ` Stefan Lengfeld
2017-06-28 8:16 ` Uwe Kleine-König
2017-06-30 6:35 ` Sascha Hauer [this message]
2017-06-30 9:06 ` Uwe Kleine-König
2017-06-30 9:28 ` Sascha Hauer
2017-06-30 19:46 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630063547.cji5g7inho5efioo@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=contact@stefanchrist.eu \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox