[PATCH] ARM: socfpga: remove unused fpgaintf setup

[PATCH] ARM: socfpga: remove unused fpgaintf setup

[Steffen Trumtrar]

The disable bits for the ethernet interfaces between FPGA and HPS are read
and configured, but never written back.
The configuration itself doesn't make that much sense however. So instead of
writing it back to the register, remove the whole read-modify operation altogether.

Reported-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/mach-socfpga/arria10-generic.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/mach-socfpga/arria10-generic.c b/arch/arm/mach-socfpga/arria10-generic.c
index b8129eaf23ff..6a10c19d1417 100644
--- a/arch/arm/mach-socfpga/arria10-generic.c
+++ b/arch/arm/mach-socfpga/arria10-generic.c
@@ -37,14 +37,6 @@ static void arria10_init_emac(void)
 	val |= ARRIA10_SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RGMII;
 	writel(val, ARRIA10_SYSMGR_EMAC2);
 
-	val = readl(ARRIA10_SYSMGR_FPGAINTF_EN_3);
-	val &= ~(ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC0 |
-		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC0_SW |
-		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC1 |
-		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC1_SW |
-		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC2 |
-		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC2_SW);
-
 	rst = readl(ARRIA10_RSTMGR_ADDR + ARRIA10_RSTMGR_PER0MODRST);
 	rst &= ~(ARRIA10_RSTMGR_PER0MODRST_EMAC0 |
 		 ARRIA10_RSTMGR_PER0MODRST_EMAC1 |
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: socfpga: remove unused fpgaintf setup

[Sascha Hauer]

On Fri, Jun 30, 2017 at 10:08:22AM +0200, Steffen Trumtrar wrote:
> The disable bits for the ethernet interfaces between FPGA and HPS are read
> and configured, but never written back.
> The configuration itself doesn't make that much sense however. So instead of
> writing it back to the register, remove the whole read-modify operation altogether.
> 
> Reported-by: Ian Abbott <abbotti@mev.co.uk>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  arch/arm/mach-socfpga/arria10-generic.c | 8 --------
>  1 file changed, 8 deletions(-)
> 

Applied, thanks

Sascha

> diff --git a/arch/arm/mach-socfpga/arria10-generic.c b/arch/arm/mach-socfpga/arria10-generic.c
> index b8129eaf23ff..6a10c19d1417 100644
> --- a/arch/arm/mach-socfpga/arria10-generic.c
> +++ b/arch/arm/mach-socfpga/arria10-generic.c
> @@ -37,14 +37,6 @@ static void arria10_init_emac(void)
>  	val |= ARRIA10_SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RGMII;
>  	writel(val, ARRIA10_SYSMGR_EMAC2);
>  
> -	val = readl(ARRIA10_SYSMGR_FPGAINTF_EN_3);
> -	val &= ~(ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC0 |
> -		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC0_SW |
> -		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC1 |
> -		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC1_SW |
> -		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC2 |
> -		 ARRIA10_SYSMGR_FPGAINTF_EN3_EMAC2_SW);
> -
>  	rst = readl(ARRIA10_RSTMGR_ADDR + ARRIA10_RSTMGR_PER0MODRST);
>  	rst &= ~(ARRIA10_RSTMGR_PER0MODRST_EMAC0 |
>  		 ARRIA10_RSTMGR_PER0MODRST_EMAC1 |
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox