mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: imx: use register defines in imxcfg files instead of plain numbers
Date: Thu, 6 Jul 2017 12:11:26 +0200	[thread overview]
Message-ID: <20170706101126.lb23q2t3v4c5mqh5@pengutronix.de> (raw)
In-Reply-To: <1499330981.22075.48.camel@pengutronix.de>

On Thu, Jul 06, 2017 at 10:49:41AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 05.07.2017, 21:23 +0200 schrieb Uwe Kleine-König:
> > This makes the imxcfg files more readable and also makes it possible to
> > share more assignments between machines that just differ by the used
> > SoC. (Though I have to admit that in the cases converted here it just
> > more easily allows to see that the RAM config differs more than probably
> > necessary.)
> > 
> > This change is intended to have no effect on the built artifacts.
> 
> Does the "intended" in the above sentence mean you didn't validate that
> the the generated flash headers are equal before and after the change in
> any way? As much as I like the patch otherwise, this sounds scary.

I verified it for some of them. I created a .config that enables all
affected machine, but not for all of them a corresponding .dcd was
generated. The one that existed then however didn't change with my
patch.

	$ grep HIPER .config
	CONFIG_MACH_ELTEC_HIPERCAM=y

	$ armmake
	...

	$ find -name \*.dcd | sort
	./arch/arm/boards/cm-fx6/flash-header-mx6-cm-fx6.dcd
	./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6q-micron.dcd
	./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6q-nanya.dcd
	./arch/arm/boards/dfi-fs700-m60/flash-header-fs700-m60-6s.dcd
	./arch/arm/boards/embedsky-e9/flash-header-e9.dcd
	./arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.dcd
	./arch/arm/boards/freescale-mx6-sabrelite/flash-header-mx6-sabrelite.dcd
	./arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6-sabresd.dcd
	./arch/arm/boards/gk802/flash-header.dcd
	./arch/arm/boards/technexion-pico-hobbit/flash-header-imx6ul-pico-hobbit-256.dcd
	./arch/arm/boards/technexion-pico-hobbit/flash-header-imx6ul-pico-hobbit-512.dcd
	./arch/arm/boards/technexion-wandboard/flash-header-technexion-wandboard.dcd
	./arch/arm/boards/tqma6x/flash-header-tqma6dl.dcd
	./arch/arm/boards/tqma6x/flash-header-tqma6q.dcd
	./arch/arm/boards/udoo/flash-header-mx6-udoo.dcd
	./arch/arm/boards/variscite-mx6/flash-header-variscite.dcd

missing (and so unchecked) are:

	flash-header-eltec-hipercam.imxcfg
	karo-tx6x/*
	phytec-som-imx6/*
	zii-imx6q-rdu2/*

even though:

	$ grep -E 'HIPER|TX6|_SOM|RDU2' .config
	CONFIG_MACH_PHYTEC_SOM_IMX6=y
	CONFIG_MACH_ELTEC_HIPERCAM=y
	CONFIG_MACH_TX6X=y
	CONFIG_MACH_ZII_RDU2=y

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-07-06 10:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 19:23 Uwe Kleine-König
2017-07-06  8:49 ` Lucas Stach
2017-07-06 10:11   ` Uwe Kleine-König [this message]
2017-07-06 10:23     ` Lucas Stach
2017-07-06 18:47       ` Uwe Kleine-König
2017-07-10 10:59 ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706101126.lb23q2t3v4c5mqh5@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox