From: Oleksij Rempel <linux@rempel-privat.de>
To: barebox@lists.infradead.org
Cc: Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH v1] net: ag71xx: disable eth interface on barebox shutdown
Date: Mon, 18 Sep 2017 18:41:45 +0200 [thread overview]
Message-ID: <20170918164145.21235-1-linux@rempel-privat.de> (raw)
If not disable, DMA RX engine will keep to write in to allocated
memory area. As soon as some code or data of target OS will be placed to
this area it will be overwritten by incoming network package.
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
drivers/net/ag71xx.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ag71xx.c b/drivers/net/ag71xx.c
index 54f0bd9aa..1cec26360 100644
--- a/drivers/net/ag71xx.c
+++ b/drivers/net/ag71xx.c
@@ -578,6 +578,7 @@ static int ag71xx_probe(struct device_d *dev)
priv = xzalloc(sizeof(struct ag71xx));
edev = &priv->netdev;
miibus = &priv->miibus;
+ dev->priv = edev;
edev->priv = priv;
edev->init = ag71xx_ether_init;
@@ -659,6 +660,13 @@ static int ag71xx_probe(struct device_d *dev)
return 0;
}
+static void ag71xx_remove(struct device_d *dev)
+{
+ struct eth_device *edev = dev->priv;
+
+ ag71xx_ether_halt(edev);
+}
+
static __maybe_unused struct of_device_id ag71xx_dt_ids[] = {
{ .compatible = "qca,ar9331-ge0", .data = &ag71xx_cfg_ar9331_ge0, },
{ .compatible = "qca,ar9344-gmac0", .data = &ag71xx_cfg_ar9344_gmac0, },
@@ -668,6 +676,7 @@ static __maybe_unused struct of_device_id ag71xx_dt_ids[] = {
static struct driver_d ag71xx_driver = {
.name = "ag71xx-gmac",
.probe = ag71xx_probe,
+ .remove = ag71xx_remove,
.of_compatible = DRV_OF_COMPAT(ag71xx_dt_ids),
};
device_platform_driver(ag71xx_driver);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2017-09-18 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 16:41 Oleksij Rempel [this message]
2017-09-20 6:22 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918164145.21235-1-linux@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox