mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] Make finding fixup nodes more robust
Date: Fri, 26 Jan 2018 21:46:32 +0100	[thread overview]
Message-ID: <20180126204632.GA3317@ravnborg.org> (raw)
In-Reply-To: <20180126192644.5434-1-s.hauer@pengutronix.de>

Hi Sasha.

On Fri, Jan 26, 2018 at 08:26:42PM +0100, Sascha Hauer wrote:
> Recently the node names in i.MX6 device tree files have changed. The
> leading zeroes were removed from the addresses. With this a newer
> barebox doesn't find the nodes to fixup in an old device tree and
> an older barebox doesn't find the nodes in a new device tree. To
> fix this we create new names of the nodes based on things that hopefully
> don't change: We iterate up to a node which is MMIO space mappable
> and get a name that starts with "[adr]". For the remaining parts of
> a node we add "<reg>" when the hierarchy level has a "reg" property
> and only as last fallback we add "{nodename}" in curly brackets.
> This name is safe against node name changes and also against adding
> a new hierarchy level in the device tree (when for example a bus level
> is added).
I think I was bitten by something similar while toying with display
timings.

So I think commands/of_display_timings.c would benefit
from a conversion to this new scheme too - as well as the mtd stuff
in of/partition.c

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-01-26 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 19:26 Sascha Hauer
2018-01-26 19:26 ` [PATCH 1/2] of: Add function to find the same node in another tree Sascha Hauer
2018-01-26 19:26 ` [PATCH 2/2] of: mtd: partition: Use reproducible node names for fixup Sascha Hauer
2018-01-26 20:46 ` Sam Ravnborg [this message]
2018-01-26 21:36   ` [PATCH 0/2] Make finding fixup nodes more robust Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180126204632.GA3317@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox