From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] aiodev: Constify 'unit' in 'struct aiodev'
Date: Tue, 3 Apr 2018 09:08:48 +0200 [thread overview]
Message-ID: <20180403070848.4cygxoaji652xa3k@pengutronix.de> (raw)
In-Reply-To: <20180326131445.11229-1-andrew.smirnov@gmail.com>
On Mon, Mar 26, 2018 at 06:14:45AM -0700, Andrey Smirnov wrote:
> The way it is currently used, there's no reason for 'uint' field to be
> mutable, so constify it in order to allow 'aiodev' drivers to pass
> sting literals in that field.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> include/aiodev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/include/aiodev.h b/include/aiodev.h
> index 0d4f7a294..5e38b4fab 100644
> --- a/include/aiodev.h
> +++ b/include/aiodev.h
> @@ -23,7 +23,7 @@
> struct aiodevice;
> struct aiochannel {
> int index;
> - char *unit;
> + const char *unit;
> struct aiodevice *aiodev;
>
> int value;
> --
> 2.14.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-04-03 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 13:14 Andrey Smirnov
2018-04-03 7:08 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403070848.4cygxoaji652xa3k@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox