[PATCH] net: specify device name in warning

[PATCH] net: specify device name in warning

[Vivien Didelot]

When a SoC such as VF610 has no addresses programmed for both its
interfaces, the "No MAC address set" warning can be confusing:

    booting 'net'
    WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
    WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42

This patch simply specifies the device name in the warning for clarity:

    booting 'net'
    WARNING: net: warning: No MAC address set for eth0. Using random address 5e:92:6b:b8:6e:92
    WARNING: net: warning: No MAC address set for eth1. Using random address 7e:bb:cd:7a:c1:e8

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 94954677c..da7afb014 100644
--- a/net/net.c
+++ b/net/net.c
@@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
 		char str[sizeof("xx:xx:xx:xx:xx:xx")];
 		random_ether_addr(edev->ethaddr);
 		ethaddr_to_string(edev->ethaddr, str);
-		pr_warn("warning: No MAC address set. Using random address %s\n", str);
+		pr_warn("warning: No MAC address set for %s. Using random address %s\n", edev->devname, str);
 		eth_set_ethaddr(edev, edev->ethaddr);
 	}
 
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: specify device name in warning

[Sam Ravnborg]

Hi Vivien

On Fri, May 18, 2018 at 02:06:36PM -0400, Vivien Didelot wrote:
> When a SoC such as VF610 has no addresses programmed for both its
> interfaces, the "No MAC address set" warning can be confusing:
> 
>     booting 'net'
>     WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
>     WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42
> 
> This patch simply specifies the device name in the warning for clarity:
> 
>     booting 'net'
>     WARNING: net: warning: No MAC address set for eth0. Using random address 5e:92:6b:b8:6e:92
>     WARNING: net: warning: No MAC address set for eth1. Using random address 7e:bb:cd:7a:c1:e8
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>  net/net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/net.c b/net/net.c
> index 94954677c..da7afb014 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
>  		char str[sizeof("xx:xx:xx:xx:xx:xx")];
>  		random_ether_addr(edev->ethaddr);
>  		ethaddr_to_string(edev->ethaddr, str);
> -		pr_warn("warning: No MAC address set. Using random address %s\n", str);
> +		pr_warn("warning: No MAC address set for %s. Using random address %s\n", edev->devname, str);
>  		eth_set_ethaddr(edev, edev->ethaddr);

You have a device - so a more consistent way seems to use dev_warn()

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: specify device name in warning

[Vivien Didelot]

Hi Sam,

Sam Ravnborg <sam@ravnborg.org> writes:

> On Fri, May 18, 2018 at 02:06:36PM -0400, Vivien Didelot wrote:
>> When a SoC such as VF610 has no addresses programmed for both its
>> interfaces, the "No MAC address set" warning can be confusing:
>> 
>>     booting 'net'
>>     WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01
>>     WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42
>> 
>> This patch simply specifies the device name in the warning for clarity:
>> 
>>     booting 'net'
>>     WARNING: net: warning: No MAC address set for eth0. Using random address 5e:92:6b:b8:6e:92
>>     WARNING: net: warning: No MAC address set for eth1. Using random address 7e:bb:cd:7a:c1:e8
>> 
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> ---
>>  net/net.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/net/net.c b/net/net.c
>> index 94954677c..da7afb014 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
>>  		char str[sizeof("xx:xx:xx:xx:xx:xx")];
>>  		random_ether_addr(edev->ethaddr);
>>  		ethaddr_to_string(edev->ethaddr, str);
>> -		pr_warn("warning: No MAC address set. Using random address %s\n", str);
>> +		pr_warn("warning: No MAC address set for %s. Using random address %s\n", edev->devname, str);
>>  		eth_set_ethaddr(edev, edev->ethaddr);
>
> You have a device - so a more consistent way seems to use dev_warn()

This looks better indeed, I'll respin!


Thanks,

        Vivien

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox