mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/2] imx-usb-loader: dump memory bytewise on verification mismatch
Date: Thu, 24 May 2018 07:36:21 +0200	[thread overview]
Message-ID: <20180524053621.995-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20180524053621.995-1-s.hauer@pengutronix.de>

dump_long only prints the full words and does not print the unaligned
rest. This means that some bytes (and maybe actually the interesting
ones) may not be printed. Use dump_bytes instead which does not have
this problem.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 scripts/imx/imx-usb-loader.c | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
index 684e3f8a06..9a690e49c8 100644
--- a/scripts/imx/imx-usb-loader.c
+++ b/scripts/imx/imx-usb-loader.c
@@ -329,28 +329,6 @@ static libusb_device *find_imx_dev(libusb_device **devs, const struct mach_id **
 	return NULL;
 }
 
-static void dump_long(const void *src, unsigned cnt, unsigned addr)
-{
-	const unsigned *p = (unsigned *)src;
-
-	while (cnt >= 32) {
-		printf("%08x: %08x %08x %08x %08x  %08x %08x %08x %08x\n",
-				addr, p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7]);
-		p += 8;
-		cnt -= 32;
-		addr += 32;
-	}
-	if (cnt) {
-		printf("%08x:", addr);
-		while (cnt >= 4) {
-			printf(" %08x", p[0]);
-			p++;
-			cnt -= 4;
-		}
-		printf("\n");
-	}
-}
-
 static void dump_bytes(const void *src, unsigned cnt, unsigned addr)
 {
 	const unsigned char *p = src;
@@ -1177,9 +1155,9 @@ static int verify_memory(const void *buf, unsigned len, unsigned addr)
 
 		if (memcmp(buf + offset, readbuf + offset, now)) {
 			printf("mismatch at offset 0x%08x. expected:\n", offset);
-			dump_long(buf + offset, now, addr + offset);
+			dump_bytes(buf + offset, now, addr + offset);
 			printf("read:\n");
-			dump_long(readbuf + offset, now, addr + offset);
+			dump_bytes(readbuf + offset, now, addr + offset);
 			ret = -EINVAL;
 			mismatch++;
 			if (mismatch > 4)
-- 
2.17.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-05-24  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24  5:36 [PATCH 1/2] imx-usb-loader: Fix verify for non word aligned lengths Sascha Hauer
2018-05-24  5:36 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524053621.995-2-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox