From: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
To: "Baeuerle, Florian" <Florian.Baeuerle@allegion.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] commands/of_property: add option to apply changes as fixup
Date: Fri, 25 May 2018 10:39:10 +0200 [thread overview]
Message-ID: <20180525083910.rv3p7mi5keoc7i5h@pengutronix.de> (raw)
In-Reply-To: <bd4f70ba1cfd3b817494cc4629bed17a5015a714.camel@allegion.com>
On Fri, May 25, 2018 at 08:23:58AM +0000, Baeuerle, Florian wrote:
> Hi Sascha,
>
> Thanks for the review!
>
> I've got one more question (below).
>
> Am Freitag, den 25.05.2018, 09:11 +0200 schrieb Sascha Hauer:
> > HI Florian,
> >
> > looks good generally. Some small comments below.
> >
> > On Thu, May 24, 2018 at 02:48:47PM +0000, Baeuerle, Florian wrote:
> > > +static int of_fixup_property_set(struct device_node *root, void *context)
> > > +{
> > > + const struct of_fixup_property_data *fixup = context;
> > > + int ret = do_of_property_set_now(root, fixup->path, fixup->propname,
> > > + fixup->data, fixup->len);
> > > +
> > > + free(fixup->path);
> > > + free(fixup->propname);
> > > + free(fixup->data);
> >
> > Don't free here. A fixup can be called multiple times.
>
> It looks like I should not free at all (of_fixup_status neither does).
> Can you confirm that?
Yes.
Freeing should be done at of_unregister_fixup time, but that doesn't
exist (yet).
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-05-25 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 14:48 Baeuerle, Florian
2018-05-25 7:11 ` Sascha Hauer
2018-05-25 8:23 ` Baeuerle, Florian
2018-05-25 8:39 ` s.hauer [this message]
2018-05-25 8:06 ` Baeuerle, Florian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525083910.rv3p7mi5keoc7i5h@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Florian.Baeuerle@allegion.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox