From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: barebox large disk problem
Date: Mon, 4 Jun 2018 12:05:41 +0200 [thread overview]
Message-ID: <20180604100541.reigx6ufnln4i5av@pengutronix.de> (raw)
In-Reply-To: <20180604125441.539e9f31bc7efd63068c5796@gmail.com>
On Mon, Jun 04, 2018 at 12:54:41PM +0300, Antony Pavlov wrote:
> Hi!
>
> I'm trying to use ST2000DM006-2DM164 SATA 2000 GB hard disk with barebox.
> This disk has 3907029168 sectors.
>
> Alas barebox uses 32-bit signed integer to store disk sector count
> (int num_blocks from struct block_device, see include/block.h for details)
> and hereby the ST2000DM006 disk is too large for barebox.
>
> I'm planning to increase block_device.num_block size from 32bit to 64bit.
> But changing struct block_device may have some unobvious drawbacks
> and I can't test all block_device usage situations (e.g. EFI).
>
> Any suggestions?
You do the change and send it to the list, we'll review it carefully ;)
In case of EFI I assume you mean the efi-block-io driver. Here EFI
internally works with 64bit variables anyway which we narrow down to
32bit for barebox. Using the 64bit variables instead shouldn't have any
undesired side effects.
It could be that some architectures lack some 64bit modulo or div
operations, but we'll notice that in the compile test.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-06-04 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 9:54 Antony Pavlov
2018-06-04 10:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604100541.reigx6ufnln4i5av@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox