mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: imx6sx: use correct clocks for GPT
Date: Thu, 7 Jun 2018 11:23:41 +0200	[thread overview]
Message-ID: <20180607092341.uzh4yg5jh4nb7mqw@pengutronix.de> (raw)
In-Reply-To: <20180605150802.24898-1-l.stach@pengutronix.de>

On Tue, Jun 05, 2018 at 05:08:02PM +0200, Lucas Stach wrote:
> This is a stop gap solution until the upstream DT is fixed. In Linux this isn't
> an issue as the driver prefers the "osc_per" clock, falling back to "per" and
> then doing different things based on the SoC type and if the input clock rate
> matches 3MHz. As this isn't really how the hardware works, but a fragile mix of
> the clock driver exposing a clock with a faked frequency and system knowledge in
> the GPT driver I prefer not to replicate this horrors in the Barebox driver,
> but instead just use the system clock source.
> 
> Fixes: 2ebda864f837
>        (ARM: imx: clocksource: Use per clock for determining parent freq)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/dts/imx6sx.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/dts/imx6sx.dtsi b/arch/arm/dts/imx6sx.dtsi
> index 5a8ee464460a..52424199f47c 100644
> --- a/arch/arm/dts/imx6sx.dtsi
> +++ b/arch/arm/dts/imx6sx.dtsi
> @@ -10,3 +10,7 @@
>  		pwm7 = &pwm8;
>  	};
>  };
> +
> +&gpt {
> +	clocks = <&clks IMX6SX_CLK_GPT_BUS>, <&clks IMX6SX_CLK_GPT_SERIAL>;
> +};
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-06-07  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 15:08 Lucas Stach
2018-06-07  9:23 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607092341.uzh4yg5jh4nb7mqw@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox