From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fRD0l-0007Eo-Ug for barebox@lists.infradead.org; Fri, 08 Jun 2018 08:45:27 +0000 Date: Fri, 8 Jun 2018 10:44:30 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20180608084430.ojrdnn5oonfo3twb@pengutronix.de> References: <20180601180750.5436-1-u.kleine-koenig@pengutronix.de> <20180601180750.5436-2-u.kleine-koenig@pengutronix.de> <20180607205301.wepjy427l3dyuqds@pengutronix.de> <20180608071044.d2zobfrrwkluuaei@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180608071044.d2zobfrrwkluuaei@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/4] libfile: implement new helper write_file_flash() To: Sascha Hauer Cc: barebox@lists.infradead.org Hello Sascha, On Fri, Jun 08, 2018 at 09:10:44AM +0200, Sascha Hauer wrote: > On Thu, Jun 07, 2018 at 10:53:01PM +0200, Uwe Kleine-K=F6nig wrote: > > On Fri, Jun 01, 2018 at 08:07:48PM +0200, Uwe Kleine-K=F6nig wrote: > > > + fd =3D open(filename, O_WRONLY | O_TRUNC | O_CREAT); > > = > > This doesn't work on the target machine (dove cubox) I intended to use > > it on an m25p0 device. It returns -28. When dropping O_TRUNC | O_CREAT > > it works though. So I suggest to either back out patches 3 and 4, or > > change the line above to O_WRONLY (which also matches the function > > removed in patch 4). > = > Ok, changed to O_WRONLY only. Thanks Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox