* [PATCH v2 1/2] MIPS: dts: drop skeleton.dtsi
2018-06-21 11:21 [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi Antony Pavlov
@ 2018-06-21 11:21 ` Antony Pavlov
2018-06-21 11:21 ` [PATCH v2 2/2] MIPS: dts: fix dtc unit_address_vs_reg warning Antony Pavlov
2018-06-25 20:02 ` [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Antony Pavlov @ 2018-06-21 11:21 UTC (permalink / raw)
To: barebox
Based on feedback from Sascha:
http://lists.infradead.org/pipermail/barebox/2018-April/032694.html
"
skeleton.dtsi should no longer be used
"
Several reasons to remove skeleton.dtsi are explained in
the linux commit 3ebee5a2e141 ("arm64: dts: kill skeleton.dtsi").
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/dts/dlink-dir-320.dts | 6 ++++--
arch/mips/dts/jz4755.dtsi | 5 +++--
arch/mips/dts/jz4780.dtsi | 5 +++--
arch/mips/dts/loongson-ls1b.dts | 1 +
arch/mips/dts/ls1b.dtsi | 5 +++--
arch/mips/dts/qemu-malta.dts | 6 ++++--
arch/mips/dts/rzx50.dts | 1 +
arch/mips/dts/skeleton.dtsi | 13 -------------
8 files changed, 19 insertions(+), 23 deletions(-)
diff --git a/arch/mips/dts/dlink-dir-320.dts b/arch/mips/dts/dlink-dir-320.dts
index b961c9dca3..966c9b362d 100644
--- a/arch/mips/dts/dlink-dir-320.dts
+++ b/arch/mips/dts/dlink-dir-320.dts
@@ -1,12 +1,14 @@
/dts-v1/;
-#include "skeleton.dtsi"
-
/ {
model = "D-Link DIR-320";
compatible = "dlink,dir320";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
memory {
+ device_type = "memory";
reg = <0x00000000 0x2000000>;
};
diff --git a/arch/mips/dts/jz4755.dtsi b/arch/mips/dts/jz4755.dtsi
index 137156df7e..5d929c5d83 100644
--- a/arch/mips/dts/jz4755.dtsi
+++ b/arch/mips/dts/jz4755.dtsi
@@ -1,6 +1,7 @@
-#include "skeleton.dtsi"
-
/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
soc {
compatible = "simple-bus";
model = "Ingenic JZ4755";
diff --git a/arch/mips/dts/jz4780.dtsi b/arch/mips/dts/jz4780.dtsi
index 9f0de5d1ae..fbffe814bb 100644
--- a/arch/mips/dts/jz4780.dtsi
+++ b/arch/mips/dts/jz4780.dtsi
@@ -1,6 +1,7 @@
-#include "skeleton.dtsi"
-
/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
soc {
model = "Ingenic JZ4780";
#address-cells = <1>;
diff --git a/arch/mips/dts/loongson-ls1b.dts b/arch/mips/dts/loongson-ls1b.dts
index b81a951dc7..61e9a2d2aa 100644
--- a/arch/mips/dts/loongson-ls1b.dts
+++ b/arch/mips/dts/loongson-ls1b.dts
@@ -7,6 +7,7 @@
compatible = "loongson,ls1b";
memory {
+ device_type = "memory";
reg = <0x00000000 0x4000000>;
};
};
diff --git a/arch/mips/dts/ls1b.dtsi b/arch/mips/dts/ls1b.dtsi
index af7119f1d0..cb85814af4 100644
--- a/arch/mips/dts/ls1b.dtsi
+++ b/arch/mips/dts/ls1b.dtsi
@@ -1,6 +1,7 @@
-#include "skeleton.dtsi"
-
/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
soc {
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/mips/dts/qemu-malta.dts b/arch/mips/dts/qemu-malta.dts
index 9b0c594e87..546b129f85 100644
--- a/arch/mips/dts/qemu-malta.dts
+++ b/arch/mips/dts/qemu-malta.dts
@@ -1,11 +1,12 @@
/dts-v1/;
-/include/ "skeleton.dtsi"
-
/ {
model = "qemu malta";
compatible = "qemu,malta";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
chosen {
environment@0 {
compatible = "barebox,environment";
@@ -14,6 +15,7 @@
};
memory {
+ device_type = "memory";
reg = <0x00000000 0x10000000>;
};
diff --git a/arch/mips/dts/rzx50.dts b/arch/mips/dts/rzx50.dts
index 7ec3352666..2896cbae82 100644
--- a/arch/mips/dts/rzx50.dts
+++ b/arch/mips/dts/rzx50.dts
@@ -7,6 +7,7 @@
compatible = "ritmix,rzx50";
memory {
+ device_type = "memory";
reg = <0x00000000 0x4000000>;
};
diff --git a/arch/mips/dts/skeleton.dtsi b/arch/mips/dts/skeleton.dtsi
deleted file mode 100644
index b41d241de2..0000000000
--- a/arch/mips/dts/skeleton.dtsi
+++ /dev/null
@@ -1,13 +0,0 @@
-/*
- * Skeleton device tree; the bare minimum needed to boot; just include and
- * add a compatible value. The bootloader will typically populate the memory
- * node.
- */
-
-/ {
- #address-cells = <1>;
- #size-cells = <1>;
- chosen { };
- aliases { };
- memory { device_type = "memory"; reg = <0 0>; };
-};
--
2.17.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 2/2] MIPS: dts: fix dtc unit_address_vs_reg warning
2018-06-21 11:21 [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi Antony Pavlov
2018-06-21 11:21 ` [PATCH v2 1/2] " Antony Pavlov
@ 2018-06-21 11:21 ` Antony Pavlov
2018-06-25 20:02 ` [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Antony Pavlov @ 2018-06-21 11:21 UTC (permalink / raw)
To: barebox
Unit number is added to the /memory nodes to fix this dtc warning:
Warning (unit_address_vs_reg): /memory: node has a reg or ranges
property, but no unit name
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/dts/dlink-dir-320.dts | 2 +-
arch/mips/dts/img-ci20.dts | 2 +-
arch/mips/dts/loongson-ls1b.dts | 2 +-
arch/mips/dts/qemu-malta.dts | 2 +-
arch/mips/dts/rzx50.dts | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips/dts/dlink-dir-320.dts b/arch/mips/dts/dlink-dir-320.dts
index 966c9b362d..d19c3087d0 100644
--- a/arch/mips/dts/dlink-dir-320.dts
+++ b/arch/mips/dts/dlink-dir-320.dts
@@ -7,7 +7,7 @@
#address-cells = <1>;
#size-cells = <1>;
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x00000000 0x2000000>;
};
diff --git a/arch/mips/dts/img-ci20.dts b/arch/mips/dts/img-ci20.dts
index da2a5bf625..d985666020 100644
--- a/arch/mips/dts/img-ci20.dts
+++ b/arch/mips/dts/img-ci20.dts
@@ -24,7 +24,7 @@
model = "MIPS Creator CI20";
compatible = "img,ci20";
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x0 0x10000000>;
};
diff --git a/arch/mips/dts/loongson-ls1b.dts b/arch/mips/dts/loongson-ls1b.dts
index 61e9a2d2aa..6b53311982 100644
--- a/arch/mips/dts/loongson-ls1b.dts
+++ b/arch/mips/dts/loongson-ls1b.dts
@@ -6,7 +6,7 @@
model = "Loongson Tech LS1B Demo Board";
compatible = "loongson,ls1b";
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x00000000 0x4000000>;
};
diff --git a/arch/mips/dts/qemu-malta.dts b/arch/mips/dts/qemu-malta.dts
index 546b129f85..9772d49eb3 100644
--- a/arch/mips/dts/qemu-malta.dts
+++ b/arch/mips/dts/qemu-malta.dts
@@ -14,7 +14,7 @@
};
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x00000000 0x10000000>;
};
diff --git a/arch/mips/dts/rzx50.dts b/arch/mips/dts/rzx50.dts
index 2896cbae82..bd3631f7c4 100644
--- a/arch/mips/dts/rzx50.dts
+++ b/arch/mips/dts/rzx50.dts
@@ -6,7 +6,7 @@
model = "Ritmix RZX-50";
compatible = "ritmix,rzx50";
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x00000000 0x4000000>;
};
--
2.17.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi
2018-06-21 11:21 [PATCH v2 0/2] MIPS: dts: drop skeleton.dtsi Antony Pavlov
2018-06-21 11:21 ` [PATCH v2 1/2] " Antony Pavlov
2018-06-21 11:21 ` [PATCH v2 2/2] MIPS: dts: fix dtc unit_address_vs_reg warning Antony Pavlov
@ 2018-06-25 20:02 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2018-06-25 20:02 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox
On Thu, Jun 21, 2018 at 02:21:18PM +0300, Antony Pavlov wrote:
> Changes since v1 patchseries:
>
> * add `device_type = "memory";` to the memory node;
> * split patch.
>
> Antony Pavlov (2):
> MIPS: dts: drop skeleton.dtsi
> MIPS: dts: fix dtc unit_address_vs_reg warning
Applied, thanks
Sascha
>
> arch/mips/dts/dlink-dir-320.dts | 8 +++++---
> arch/mips/dts/img-ci20.dts | 2 +-
> arch/mips/dts/jz4755.dtsi | 5 +++--
> arch/mips/dts/jz4780.dtsi | 5 +++--
> arch/mips/dts/loongson-ls1b.dts | 3 ++-
> arch/mips/dts/ls1b.dtsi | 5 +++--
> arch/mips/dts/qemu-malta.dts | 8 +++++---
> arch/mips/dts/rzx50.dts | 3 ++-
> arch/mips/dts/skeleton.dtsi | 13 -------------
> 9 files changed, 24 insertions(+), 28 deletions(-)
> delete mode 100644 arch/mips/dts/skeleton.dtsi
>
> --
> 2.17.0
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread