From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 3/6] watchdog: rave-sp-wdt: Remove bogus leftover code
Date: Sun, 24 Jun 2018 15:26:20 -0700 [thread overview]
Message-ID: <20180624222623.30564-4-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180624222623.30564-1-andrew.smirnov@gmail.com>
This code should've been removed when the driver was rebased against
latest watchdog plumbing in Barebox.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/watchdog/rave-sp-wdt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/watchdog/rave-sp-wdt.c b/drivers/watchdog/rave-sp-wdt.c
index 164316785..bd1c43b0f 100644
--- a/drivers/watchdog/rave-sp-wdt.c
+++ b/drivers/watchdog/rave-sp-wdt.c
@@ -75,7 +75,6 @@ struct rave_sp_wdt {
struct restart_handler restart;
unsigned int timeout;
unsigned int boot_source;
- struct device_d dev;
};
static struct rave_sp_wdt *to_rave_sp_wdt(struct watchdog *wdd)
@@ -357,10 +356,8 @@ static int rave_sp_wdt_probe(struct device_d *dev)
rave_sp_wdt_set_boot_source,
rave_sp_wdt_get_boot_source,
&sp_wd->boot_source, "%u", sp_wd);
- if (IS_ERR(p)) {
- unregister_device(&sp_wd->dev);
+ if (IS_ERR(p))
return PTR_ERR(p);
- }
ret = sp_wd->variant->reset_reason(wdd);
if (ret < 0) {
--
2.17.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-06-24 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 22:26 [PATCH 0/6] RAVE SP RDU2-related changes Andrey Smirnov
2018-06-24 22:26 ` [PATCH 1/6] ARM: dts: rdu2: Remove obsolete 'pic' node in uart4 Andrey Smirnov
2018-06-24 22:26 ` [PATCH 2/6] ARM: dts: rdu2: Add nodes for RAVE SP EEPROM Andrey Smirnov
2018-06-24 22:26 ` Andrey Smirnov [this message]
2018-06-24 22:26 ` [PATCH 4/6] watchdog: rave-sp-wdt: Explicitly access EEPROM for bootsource Andrey Smirnov
2018-06-24 22:26 ` [PATCH 5/6] ARM: dts: rdu2: Specify "boot-source" NVMEM cell Andrey Smirnov
2018-06-24 22:26 ` [PATCH 6/6] ARM: dts: rdu2: Add node for backlight device Andrey Smirnov
2018-06-26 4:59 ` [PATCH 0/6] RAVE SP RDU2-related changes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624222623.30564-4-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox