mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH] net: eth: Make use of ETH_ALEN
Date: Thu,  9 Aug 2018 15:46:25 -0700	[thread overview]
Message-ID: <20180809224625.20993-1-andrew.smirnov@gmail.com> (raw)

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 net/eth.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/net/eth.c b/net/eth.c
index 5d45a0461..9dc441195 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -40,7 +40,7 @@ LIST_HEAD(netdev_list);
 
 struct eth_ethaddr {
 	struct list_head list;
-	u8 ethaddr[6];
+	u8 ethaddr[ETH_ALEN];
 	int ethid;
 	struct device_node *node;
 };
@@ -82,7 +82,7 @@ static int eth_get_registered_ethaddr(struct eth_device *edev, void *buf)
 	list_for_each_entry(addr, &ethaddr_list, list) {
 		if ((node && node == addr->node) ||
 				addr->ethid == edev->dev.id) {
-			memcpy(buf, addr->ethaddr, 6);
+			memcpy(buf, addr->ethaddr, ETH_ALEN);
 			return 0;
 		}
 	}
@@ -118,7 +118,7 @@ void eth_register_ethaddr(int ethid, const char *ethaddr)
 
 	addr = xzalloc(sizeof(*addr));
 	addr->ethid = ethid;
-	memcpy(addr->ethaddr, ethaddr, 6);
+	memcpy(addr->ethaddr, ethaddr, ETH_ALEN);
 	list_add_tail(&addr->list, &ethaddr_list);
 }
 
@@ -150,7 +150,7 @@ void of_eth_register_ethaddr(struct device_node *node, const char *ethaddr)
 
 	addr = xzalloc(sizeof(*addr));
 	addr->node = node;
-	memcpy(addr->ethaddr, ethaddr, 6);
+	memcpy(addr->ethaddr, ethaddr, ETH_ALEN);
 	list_add_tail(&addr->list, &ethaddr_list);
 }
 
@@ -284,7 +284,7 @@ static int eth_param_set_ethaddr(struct param_d *param, void *priv)
 #ifdef CONFIG_OFTREE
 static void eth_of_fixup_node(struct device_node *root,
 			      const char *node_path, int ethid,
-			      const u8 ethaddr[6])
+			      const u8 ethaddr[ETH_ALEN])
 {
 	struct device_node *node;
 	int ret;
@@ -308,7 +308,7 @@ static void eth_of_fixup_node(struct device_node *root,
 		return;
 	}
 
-	ret = of_set_property(node, "mac-address", ethaddr, 6, 1);
+	ret = of_set_property(node, "mac-address", ethaddr, ETH_ALEN, 1);
 	if (ret)
 		pr_err("Setting mac-address property of %s failed with: %s\n",
 		       node->full_name, strerror(-ret));
@@ -355,7 +355,7 @@ static const char * const eth_mode_names[] = {
 int eth_register(struct eth_device *edev)
 {
 	struct device_d *dev = &edev->dev;
-	unsigned char ethaddr[6];
+	unsigned char ethaddr[ETH_ALEN];
 	int ret, found = 0;
 
 	if (!edev->get_ethaddr) {
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-08-09 22:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 22:46 Andrey Smirnov [this message]
2018-08-10  6:42 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809224625.20993-1-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox