mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH] ARM: cache-l2x0: Make use of IS_ALIGNED and ALIGN_DOWN
Date: Mon, 20 Aug 2018 23:27:17 -0700	[thread overview]
Message-ID: <20180821062717.17744-1-andrew.smirnov@gmail.com> (raw)

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/arm/cpu/cache-l2x0.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/cpu/cache-l2x0.c b/arch/arm/cpu/cache-l2x0.c
index 8e0fff66d..e975ecffc 100644
--- a/arch/arm/cpu/cache-l2x0.c
+++ b/arch/arm/cpu/cache-l2x0.c
@@ -60,14 +60,14 @@ static inline void l2x0_inv_all(void)
 
 static void l2x0_inv_range(unsigned long start, unsigned long end)
 {
-	if (start & (CACHE_LINE_SIZE - 1)) {
-		start &= ~(CACHE_LINE_SIZE - 1);
+	if (!IS_ALIGNED(start, CACHE_LINE_SIZE)) {
+		start = ALIGN_DOWN(start, CACHE_LINE_SIZE);
 		l2x0_flush_line(start);
 		start += CACHE_LINE_SIZE;
 	}
 
-	if (end & (CACHE_LINE_SIZE - 1)) {
-		end &= ~(CACHE_LINE_SIZE - 1);
+	if (!IS_ALIGNED(end, CACHE_LINE_SIZE)) {
+		end = ALIGN_DOWN(end, CACHE_LINE_SIZE);
 		l2x0_flush_line(end);
 	}
 
@@ -87,7 +87,7 @@ static void l2x0_clean_range(unsigned long start, unsigned long end)
 {
 	void __iomem *base = l2x0_base;
 
-	start &= ~(CACHE_LINE_SIZE - 1);
+	start = ALIGN_DOWN(start, CACHE_LINE_SIZE);
 	while (start < end) {
 		unsigned long blk_end = start + min(end - start, 4096UL);
 
@@ -102,7 +102,7 @@ static void l2x0_clean_range(unsigned long start, unsigned long end)
 
 static void l2x0_flush_range(unsigned long start, unsigned long end)
 {
-	start &= ~(CACHE_LINE_SIZE - 1);
+	start = ALIGN_DOWN(start, CACHE_LINE_SIZE);
 	while (start < end) {
 		unsigned long blk_end = start + min(end - start, 4096UL);
 
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-08-21  6:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21  6:27 Andrey Smirnov [this message]
2018-08-22  7:19 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821062717.17744-1-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox