From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ft2EB-0005Vv-2Z for barebox@lists.infradead.org; Fri, 24 Aug 2018 02:53:42 +0000 Received: by mail-pl1-x644.google.com with SMTP id a4-v6so444075plm.13 for ; Thu, 23 Aug 2018 19:53:30 -0700 (PDT) From: Andrey Smirnov Date: Thu, 23 Aug 2018 19:52:42 -0700 Message-Id: <20180824025243.19479-24-andrew.smirnov@gmail.com> In-Reply-To: <20180824025243.19479-1-andrew.smirnov@gmail.com> References: <20180824025243.19479-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH v2 23/24] bbu: Report update failures explicitly To: barebox@lists.infradead.org Cc: Andrey Smirnov Change the code of barebox_update() to explicitly log that update failed instead of failing silently (unless update was interrupted) and relying on user checking the return code. Signed-off-by: Andrey Smirnov --- common/bbu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/bbu.c b/common/bbu.c index 9e206227a..3974bf672 100644 --- a/common/bbu.c +++ b/common/bbu.c @@ -260,13 +260,13 @@ int barebox_update(struct bbu_data *data) return ret; ret = handler->handler(handler, data); - if (ret == -EINTR) - printf("update aborted\n"); - - if (!ret) - printf("update succeeded\n"); + if (ret) { + printf("update %s\n", (ret == -EINTR) ? "aborted" : "failed"); + return ret; + } - return ret; + printf("update succeeded\n"); + return 0; } /* -- 2.17.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox