From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ft2h6-00070b-64 for barebox@lists.infradead.org; Fri, 24 Aug 2018 03:23:29 +0000 Received: by mail-pf1-x435.google.com with SMTP id l9-v6so3837070pff.9 for ; Thu, 23 Aug 2018 20:23:17 -0700 (PDT) From: Andrey Smirnov Date: Thu, 23 Aug 2018 20:23:01 -0700 Message-Id: <20180824032301.30467-2-andrew.smirnov@gmail.com> In-Reply-To: <20180824032301.30467-1-andrew.smirnov@gmail.com> References: <20180824032301.30467-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 2/2] ARM: i.MX: xload: Add support for signed HDMI firmware To: barebox@lists.infradead.org Cc: Andrey Smirnov When booting images that have HDMI firmware embedded we need to skip the first v2 header we encounter and get all of the necessary data from the next one. Add code implementing that. Signed-off-by: Andrey Smirnov --- arch/arm/mach-imx/xload-esdhc.c | 43 +++++++++++++++++++++++++-------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-imx/xload-esdhc.c b/arch/arm/mach-imx/xload-esdhc.c index 55d6c6929..cab024cfe 100644 --- a/arch/arm/mach-imx/xload-esdhc.c +++ b/arch/arm/mach-imx/xload-esdhc.c @@ -224,24 +224,47 @@ esdhc_start_image(struct esdhc *esdhc, ptrdiff_t address, ptrdiff_t entry, u32 o { void *buf = (void *)address; - struct imx_flash_header_v2 *hdr = buf + offset + SZ_1K; + struct imx_flash_header_v2 *hdr; int ret, len; void __noreturn (*bb)(void); unsigned int ofs; + int i, header_count = 1; len = imx_image_size(); len = ALIGN(len, SECTOR_SIZE); - ret = esdhc_read_blocks(esdhc, buf, offset + SZ_1K + SECTOR_SIZE); - if (ret) - return ret; + for (i = 0; i < header_count; i++) { + ret = esdhc_read_blocks(esdhc, buf, + offset + SZ_1K + SECTOR_SIZE); + if (ret) + return ret; - if (!is_imx_flash_header_v2(hdr)) { - pr_debug("IVT header not found on SD card. " - "Found tag: 0x%02x length: 0x%04x version: %02x\n", - hdr->header.tag, hdr->header.length, - hdr->header.version); - return -EINVAL; + hdr = buf + offset + SZ_1K; + + if (!is_imx_flash_header_v2(hdr)) { + pr_debug("IVT header not found on SD card. " + "Found tag: 0x%02x length: 0x%04x " + "version: %02x\n", + hdr->header.tag, hdr->header.length, + hdr->header.version); + return -EINVAL; + } + + if (IS_ENABLED(CONFIG_ARCH_IMX8MQ) && + hdr->boot_data.plugin & PLUGIN_HDMI_IMAGE) { + /* + * In images that include signed HDMI + * firmware, first v2 header would be + * dedicated to that and would not contain any + * useful for us information. In order for us + * to pull the rest of the bootloader image + * in, we need to re-read header from SD/MMC, + * this time skipping anything HDMI firmware + * related. + */ + offset += PLUGIN_HDMI_SIZE; + header_count++; + } } pr_debug("Check ok, loading image\n"); -- 2.17.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox