mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] imx{5,6}: reset otg port after usb-serial boot
Date: Fri, 24 Aug 2018 21:55:56 +0200	[thread overview]
Message-ID: <20180824195556.jihqkka6bj5tbqpq@pengutronix.de> (raw)
In-Reply-To: <20180824170407.geeahhgkqntovpi5@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1299 bytes --]

On Fri, Aug 24, 2018 at 07:04:07PM +0200, Sascha Hauer wrote:
> On Fri, Aug 24, 2018 at 05:17:39PM +0200, Michael Grzeschik wrote:
> > The ROM loader leaves the otg port in peripheral mode which confuses the
> > host controller. After the handover to barebox we ensure to bring in the
> > port into the otg state by resetting it.
> > 
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> > This was tested with mx53 and mx6 for now. I suppose we should
> > adopt this to the mx2 and mx3 models.
> 
> Looks like a variant of the patch I posted here:
> https://www.spinics.net/lists/u-boot-v2/msg34153.html
> I have given the reason this can't be applied directly here:
> https://www.spinics.net/lists/u-boot-v2/msg34196.html

Just toggling RS was not enough in my case.

I get that it is not safe to toggle bits if the clock is not
there. We could check for the bootsource. Is it possible to
ensure that we are started by imx-usb-loader?

mgr

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-08-24 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 15:17 Michael Grzeschik
2018-08-24 16:27 ` Sam Ravnborg
2018-08-24 17:04 ` Sascha Hauer
2018-08-24 19:55   ` Michael Grzeschik [this message]
2018-08-24 20:18     ` Fabio Estevam
2018-08-27  7:47       ` Michael Grzeschik
2018-08-27  7:52         ` Sascha Hauer
2018-08-27  8:13           ` Michael Grzeschik
2018-08-27  8:17             ` Michael Grzeschik
2018-08-27  8:29             ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824195556.jihqkka6bj5tbqpq@pengutronix.de \
    --to=mgr@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox