From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] USB: host: hub: Adjust device speed after every port reset
Date: Wed, 29 Aug 2018 09:40:04 +0200 [thread overview]
Message-ID: <20180829074004.3qjhuzdlcxauitnw@pengutronix.de> (raw)
In-Reply-To: <20180829063333.31026-2-andrew.smirnov@gmail.com>
On Tue, Aug 28, 2018 at 11:33:33PM -0700, Andrey Smirnov wrote:
> To account for the possibility of a device coming out of second reset
> operating at different speed compared to first, move the code that
> stores device speed to be a part of hub_port_reset(). This way any
> speed change happening as a result of port reset could be accounted
> for.
>
> The above behaviour was observed on i.MX51 ZII RDU1, on USBH2 port
> connected to SMSC2660 USB Hub/SD card reader. For reasons unclear,
> first reset would put it into Full Speed mode whereas second would
> result in switch to High Speed. Artifically disabling second reset
> would result in the device operating at Full Speed.
>
> Not doing second speed adjustement on that board result would result
> in un-processed control transfer and failure to execute
> usb_set_address().
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/usb/core/hub.c | 54 +++++++++++++++++++++---------------------
> drivers/usb/core/hub.h | 4 ++--
> drivers/usb/core/usb.c | 3 +--
> 3 files changed, 30 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 70f633ed8..39e5fe67d 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -112,32 +112,31 @@ static inline char *portspeed(int portstatus)
> return "12 Mb/s";
> }
>
> -int hub_port_reset(struct usb_device *dev, int port,
> - unsigned short *portstat)
> +int hub_port_reset(struct usb_device *hub, int port, struct usb_device *usb)
> {
I created a separate patch from the renaming from "dev" to "hub" and
applied this series. Thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-08-29 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 6:33 [PATCH 1/2] USB: host: hub: Make sure to remove dangling pointers Andrey Smirnov
2018-08-29 6:33 ` [PATCH 2/2] USB: host: hub: Adjust device speed after every port reset Andrey Smirnov
2018-08-29 7:40 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829074004.3qjhuzdlcxauitnw@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox