From: Sascha Hauer <s.hauer@pengutronix.de>
To: perachet7@gmail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH]: ARM/RK3188 radxa-rock sdcard boot env file: DTB location fix
Date: Tue, 18 Sep 2018 08:08:51 +0200 [thread overview]
Message-ID: <20180918060851.GI4097@pengutronix.de> (raw)
In-Reply-To: <9551553.ySa1Ws6A1a@think-future.de>
Hi,
On Mon, Sep 17, 2018 at 05:41:12PM +0200, perachet7@gmail.com wrote:
> Hi,
>
> radxa-rock/env/boot/mshc1
> index 7393c4e63..b61dd807d 100644
> --- a/arch/arm/boards/radxa-rock/env/boot/mshc1
> +++ b/arch/arm/boards/radxa-rock/env/boot/mshc1
> @@ -3,7 +3,7 @@
> mount /dev/mshc1.0
>
> global.bootm.boot_atag=true
^^^^
This should be removed also since we do not want to boot the board using
ATAGs.
Your patch lacks a Signed-off-by tag. Please add that next time you send
a patch. For this time I created a patch myself with the line above
removed.
Sascha
> -oftree -l /mnt/mshc1.0/rk3188-radxarock.dtb
> +global.bootm.oftree=/mnt/mshc1.0/rk3188-radxarock.dtb
>
> global.bootm.image=/mnt/mshc1.0/zImage
> global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootwait"
>
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-09-18 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 15:41 perachet7
2018-09-18 6:08 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918060851.GI4097@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=perachet7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox