mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 05/16] of: Demote "Bad cell count for" to debug
Date: Sun,  7 Oct 2018 23:35:31 -0700	[thread overview]
Message-ID: <20181008063542.18709-6-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20181008063542.18709-1-andrew.smirnov@gmail.com>

There are valid use-cases where getting OF_BAD_ADDR via that codepath
is expected. In addition to that analogous code in Linux kernel uses
pr_debug as well.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/of/address.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/address.c b/drivers/of/address.c
index 14db08041..4e12522a0 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -379,8 +379,8 @@ static u64 __of_translate_address(struct device_node *dev,
 	/* Count address cells & copy address locally */
 	bus->count_cells(dev, &na, &ns);
 	if (!OF_CHECK_COUNTS(na, ns)) {
-		printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
-		       dev->full_name);
+		pr_debug("prom_parse: Bad cell count for %s\n",
+			 dev->full_name);
 		return OF_BAD_ADDR;
 	}
 	memcpy(addr, in_addr, na * 4);
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-10-08  6:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  6:35 [PATCH 00/16] Andrey Smirnov
2018-10-08  6:35 ` [PATCH 01/16] ARM: Do not expose ARMv8 functions on ARMv7 Andrey Smirnov
2018-10-08  6:35 ` [PATCH 02/16] clocksource: Add ARM global timer support Andrey Smirnov
2018-10-08  8:17   ` Sascha Hauer
2018-10-08 15:37     ` Andrey Smirnov
2018-10-08  6:35 ` [PATCH 03/16] i.MX: Move GPT driver to drivers/clocksource Andrey Smirnov
2018-10-08  6:35 ` [PATCH 04/16] clocksource: Introduce ARCH_HAS_IMX_GPT Andrey Smirnov
2018-10-08  6:35 ` Andrey Smirnov [this message]
2018-10-08  6:35 ` [PATCH 06/16] drivers: Introduce dev_set_name() Andrey Smirnov
2018-10-09 15:41   ` Sam Ravnborg
2018-10-09 17:10     ` Andrey Smirnov
2018-10-08  6:35 ` [PATCH 07/16] linux: string: Port kbasename() Andrey Smirnov
2018-10-08  6:35 ` [PATCH 08/16] of: Port latest of_device_make_bus_id() implementation Andrey Smirnov
2018-10-08  6:35 ` [PATCH 09/16] mdio_bus: Fix documentation for mdio_bus_match() Andrey Smirnov
2018-10-08  6:35 ` [PATCH 10/16] include: linux: phy: Add missing PHY_INTERFACE_* constants Andrey Smirnov
2018-10-08  6:35 ` [PATCH 11/16] include: linux: ethtool: Add missing *_UNKNOWN constants Andrey Smirnov
2018-10-08  6:35 ` [PATCH 12/16] net: phy: Check phy_mask in get_phy_device() Andrey Smirnov
2018-10-08  6:35 ` [PATCH 13/16] mdio_bus: Allow for non PHY-devices on MDIO buses Andrey Smirnov
2018-10-08  8:44   ` Sascha Hauer
2018-10-08 15:41     ` Andrey Smirnov
2018-10-08  6:35 ` [PATCH 14/16] net: phy: Add basic driver for MV88E6XXX switches from Marvell Andrey Smirnov
2018-10-08  6:35 ` [PATCH 15/16] net: phy: mv88e6xxx: Port EEPROM support code Andrey Smirnov
2018-10-08  6:35 ` [PATCH 16/16] net: phy: mv88e6xxx: Add support for MAC ports Andrey Smirnov
2018-10-09 17:30 ` [PATCH 00/16] Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008063542.18709-6-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox