* [PATCH v1 1/2] ratp: fix compile warnings @ 2018-10-16 19:50 Oleksij Rempel 2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel 2018-10-18 6:59 ` [PATCH v1 1/2] ratp: " Sascha Hauer 0 siblings, 2 replies; 6+ messages in thread From: Oleksij Rempel @ 2018-10-16 19:50 UTC (permalink / raw) To: barebox; +Cc: Oleksij Rempel Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- common/ratp/ratp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/ratp/ratp.c b/common/ratp/ratp.c index fae9cec5b9..9aea1786d6 100644 --- a/common/ratp/ratp.c +++ b/common/ratp/ratp.c @@ -72,7 +72,7 @@ int register_ratp_command(struct ratp_command *cmd) } EXPORT_SYMBOL(register_ratp_command); -struct ratp_command *find_ratp_request(uint16_t request_id) +static struct ratp_command *find_ratp_request(uint16_t request_id) { struct ratp_command *cmdtp; -- 2.19.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] fs/devfs: fix compile warnings 2018-10-16 19:50 [PATCH v1 1/2] ratp: fix compile warnings Oleksij Rempel @ 2018-10-16 19:50 ` Oleksij Rempel 2018-10-17 9:22 ` Roland Hieber 2018-10-18 6:59 ` [PATCH v1 1/2] ratp: " Sascha Hauer 1 sibling, 1 reply; 6+ messages in thread From: Oleksij Rempel @ 2018-10-16 19:50 UTC (permalink / raw) To: barebox; +Cc: Oleksij Rempel Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- fs/devfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/devfs.c b/fs/devfs.c index d2b801036e..10f098280e 100644 --- a/fs/devfs.c +++ b/fs/devfs.c @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb) return &node->inode; } -int devfs_iterate(struct file *file, struct dir_context *ctx) +static int devfs_iterate(struct file *file, struct dir_context *ctx) { struct cdev *cdev; -- 2.19.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] fs/devfs: fix compile warnings 2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel @ 2018-10-17 9:22 ` Roland Hieber 2018-10-17 9:44 ` Oleksij Rempel 0 siblings, 1 reply; 6+ messages in thread From: Roland Hieber @ 2018-10-17 9:22 UTC (permalink / raw) To: Oleksij Rempel; +Cc: barebox For both of these, it would be nice to know what the compiler warnings were, in case anyone wants to grep the logs. - Roland On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > fs/devfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/devfs.c b/fs/devfs.c > index d2b801036e..10f098280e 100644 > --- a/fs/devfs.c > +++ b/fs/devfs.c > @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb) > return &node->inode; > } > > -int devfs_iterate(struct file *file, struct dir_context *ctx) > +static int devfs_iterate(struct file *file, struct dir_context *ctx) > { > struct cdev *cdev; > > -- > 2.19.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] fs/devfs: fix compile warnings 2018-10-17 9:22 ` Roland Hieber @ 2018-10-17 9:44 ` Oleksij Rempel 2018-10-17 9:55 ` Lucas Stach 0 siblings, 1 reply; 6+ messages in thread From: Oleksij Rempel @ 2018-10-17 9:44 UTC (permalink / raw) To: Roland Hieber, Oleksij Rempel; +Cc: barebox This is the list of all warnings: common/ratp/ratp.c:75:22: warning: no previous prototype for ‘find_ratp_request’ [-Wmissing-prototypes] fs/devfs.c:196:5: warning: no previous prototype for ‘devfs_iterate’ [-Wmissing-prototypes] fs/fs.c:96:18: warning: no previous prototype for ‘mntget’ [-Wmissing-prototypes] fs/fs.c:106:6: warning: no previous prototype for ‘mntput’ [-Wmissing-prototypes] fs/fs.c:114:18: warning: no previous prototype for ‘lookup_mnt’ [-Wmissing-prototypes] fs/fs.c:184:5: warning: no previous prototype for ‘create’ [-Wmissing-prototypes] fs/fs.c:612:6: warning: no previous prototype for ‘dentry_kill’ [-Wmissing-prototypes] fs/fs.c:625:5: warning: no previous prototype for ‘dentry_delete_subtree’ [-Wmissing-prototypes] fs/fs.c:1115:16: warning: no previous prototype for ‘__d_alloc’ [-Wmissing-prototypes] fs/fs.c:1155:16: warning: no previous prototype for ‘d_alloc’ [-Wmissing-prototypes] fs/fs.c:1228:16: warning: no previous prototype for ‘d_lookup’ [-Wmissing-prototypes] fs/fs.c:1244:6: warning: no previous prototype for ‘d_invalidate’ [-Wmissing-prototypes] fs/fs.c:1321:6: warning: no previous prototype for ‘path_get’ [-Wmissing-prototypes] fs/fs.c:1327:6: warning: no previous prototype for ‘path_put’ [-Wmissing-prototypes] fs/fs.c:1510:5: warning: no previous prototype for ‘follow_up’ [-Wmissing-prototypes] fs/fs.c:1702:18: warning: no previous prototype for ‘getname’ [-Wmissing-prototypes] fs/fs.c:1721:6: warning: no previous prototype for ‘putname’ [-Wmissing-prototypes] fs/fs.c:2068:5: warning: no previous prototype for ‘vfs_rmdir’ [-Wmissing-prototypes] fs/fs.c:2092:5: warning: no previous prototype for ‘vfs_mkdir’ [-Wmissing-prototypes] fs/fs.c:2351:5: warning: no previous prototype for ‘vfs_symlink’ [-Wmissing-prototypes] Not sure if make sense to list all of them. Especially if you can see from the patch diff, what the patch is doing. Am 17.10.2018 um 11:22 schrieb Roland Hieber: > For both of these, it would be nice to know what the compiler warnings > were, in case anyone wants to grep the logs. > > - Roland > > On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote: >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >> --- >> fs/devfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/devfs.c b/fs/devfs.c >> index d2b801036e..10f098280e 100644 >> --- a/fs/devfs.c >> +++ b/fs/devfs.c >> @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb) >> return &node->inode; >> } >> >> -int devfs_iterate(struct file *file, struct dir_context *ctx) >> +static int devfs_iterate(struct file *file, struct dir_context *ctx) >> { >> struct cdev *cdev; >> >> -- >> 2.19.0 >> >> >> _______________________________________________ >> barebox mailing list >> barebox@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/barebox >> > -- Regards, Oleksij _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] fs/devfs: fix compile warnings 2018-10-17 9:44 ` Oleksij Rempel @ 2018-10-17 9:55 ` Lucas Stach 0 siblings, 0 replies; 6+ messages in thread From: Lucas Stach @ 2018-10-17 9:55 UTC (permalink / raw) To: Oleksij Rempel, Roland Hieber, Oleksij Rempel; +Cc: barebox Am Mittwoch, den 17.10.2018, 11:44 +0200 schrieb Oleksij Rempel: > This is the list of all warnings: [...] > Not sure if make sense to list all of them. Especially if you can see > from the patch diff, what the patch is doing. +1 for not polluting the commit message with all this noise. But I think it would make sense to move the Wmissing-prototypes CFLAG out of the mips architecture to apply it generally across all architectures, so we don't introduce any more of those issues without noticing. Regards, Lucas > Am 17.10.2018 um 11:22 schrieb Roland Hieber: > > For both of these, it would be nice to know what the compiler warnings > > were, in case anyone wants to grep the logs. > > > > - Roland > > > > On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote: > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > --- > > > fs/devfs.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/fs/devfs.c b/fs/devfs.c > > > index d2b801036e..10f098280e 100644 > > > --- a/fs/devfs.c > > > +++ b/fs/devfs.c > > > @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb) > > > > > > return &node->inode; > > > } > > > > > > -int devfs_iterate(struct file *file, struct dir_context *ctx) > > > +static int devfs_iterate(struct file *file, struct dir_context *ctx) > > > { > > > > > > struct cdev *cdev; > > > > > > -- > > > 2.19.0 > > > > > > > > > _______________________________________________ > > > barebox mailing list > > > barebox@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/barebox > > > > > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] ratp: fix compile warnings 2018-10-16 19:50 [PATCH v1 1/2] ratp: fix compile warnings Oleksij Rempel 2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel @ 2018-10-18 6:59 ` Sascha Hauer 1 sibling, 0 replies; 6+ messages in thread From: Sascha Hauer @ 2018-10-18 6:59 UTC (permalink / raw) To: Oleksij Rempel; +Cc: barebox On Tue, Oct 16, 2018 at 09:50:21PM +0200, Oleksij Rempel wrote: > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > common/ratp/ratp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks Sascha > > diff --git a/common/ratp/ratp.c b/common/ratp/ratp.c > index fae9cec5b9..9aea1786d6 100644 > --- a/common/ratp/ratp.c > +++ b/common/ratp/ratp.c > @@ -72,7 +72,7 @@ int register_ratp_command(struct ratp_command *cmd) > } > EXPORT_SYMBOL(register_ratp_command); > > -struct ratp_command *find_ratp_request(uint16_t request_id) > +static struct ratp_command *find_ratp_request(uint16_t request_id) > { > struct ratp_command *cmdtp; > > -- > 2.19.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-18 6:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-10-16 19:50 [PATCH v1 1/2] ratp: fix compile warnings Oleksij Rempel 2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel 2018-10-17 9:22 ` Roland Hieber 2018-10-17 9:44 ` Oleksij Rempel 2018-10-17 9:55 ` Lucas Stach 2018-10-18 6:59 ` [PATCH v1 1/2] ratp: " Sascha Hauer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox