From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marcin Niestroj <m.niestroj@grinn-global.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: dhcp: fix option 54
Date: Fri, 26 Oct 2018 11:44:52 +0200 [thread overview]
Message-ID: <20181026094452.lunv5opg26u56b6j@pengutronix.de> (raw)
In-Reply-To: <20181023131531.22804-1-m.niestroj@grinn-global.com>
On Tue, Oct 23, 2018 at 03:15:31PM +0200, Marcin Niestroj wrote:
> Option 54 (Server Identifier) is something different than
> SIADDR (Server IP address). Currently they are used
> interchangeably. This causes DHCPNAK with DHCP servers that
> have configured different values for each field.
>
> Create new 'dhcp_serverip' field in 'struct dhcp_result', so we treat
> option 54 separately. This fixes DHCP requests for servers that send
> two different values for SIADDR and option 54 in DHCPOFFER.
>
> Fixes: 528298b702a0 ("net: dhcp: rework")
> Fixes: e18cc5b7e9ce ("DHCP: fix option 54 passing")
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> ---
> include/dhcp.h | 1 +
> net/dhcp.c | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
Tested here, still works for me. Other than that I must say I do not
fully overview the impact of this patch, so I just hope for the best ;)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-10-26 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 13:15 Marcin Niestroj
2018-10-26 9:44 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026094452.lunv5opg26u56b6j@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.niestroj@grinn-global.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox