From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] of: unflatten: access property properly
Date: Tue, 30 Oct 2018 08:30:36 +0100 [thread overview]
Message-ID: <20181030073036.28835-1-s.hauer@pengutronix.de> (raw)
Properties have to be accessed with of_property_get_value() rather than
accessing them directly from the devicenode. The accessor does the
right thing when of_new_property_const() is used.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 92dd86e4ec..cf3f1ee147 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -227,7 +227,7 @@ static struct device_node *__of_unflatten_dtb(const void *infdt, bool constprops
p = of_new_property(node, name, nodep, len);
if (!strcmp(name, "phandle") && len == 4)
- node->phandle = be32_to_cpup(p->value);
+ node->phandle = be32_to_cpup(of_property_get_value(p));
dt_struct = dt_struct_advance(&f, dt_struct,
sizeof(struct fdt_property) + len);
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2018-10-30 7:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030073036.28835-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox