mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Alexander Smirnov <alllecs@yandex.ru>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: common/ddr_spd.c:281:28: warning: bitwise comparison always evaluates to false
Date: Thu, 1 Nov 2018 13:52:14 +0300	[thread overview]
Message-ID: <20181101135214.c449c5d63daace2540320652@gmail.com> (raw)

Hi!

I have tried to build barebox with gcc-8.2.

I see this warning:

common/ddr_spd.c:281:28:
common/ddr_spd.c: In function ‘ddr_spd_print’:
common/ddr_spd.c:281:28: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
  if ((s->mod_ranks & 0x10) == 1)
                            ^~

Git blame show me this:

f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 280)    printf("%-48s ", "DRAM Package ");
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 281)    if ((s->mod_ranks & 0x10) == 1)
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 282)            printf("Stack\n");
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 283)    else
f75fe31095 (Alexander Smirnov 2015-07-03 18:58:24 +0300 284)            printf("Planar\n");

Please fix it.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-11-01 10:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 10:52 Antony Pavlov [this message]
2018-11-07 13:31 ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101135214.c449c5d63daace2540320652@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=alllecs@yandex.ru \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox