From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMr1r-0001pa-Mu for barebox@lists.infradead.org; Wed, 14 Nov 2018 09:00:13 +0000 Date: Wed, 14 Nov 2018 09:59:55 +0100 From: Sascha Hauer Message-ID: <20181114085955.o5hz7riqxbg2kbt6@pengutronix.de> References: <20181112162257.2209-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181112162257.2209-1-l.stach@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] video: ipuv3: use closest fractional divider To: Lucas Stach Cc: barebox@lists.infradead.org On Mon, Nov 12, 2018 at 05:22:56PM +0100, Lucas Stach wrote: > Currently the divider is always rounded down, which may lead to a > rather big overshoot of the display clock. Try to match the clock > better by rounding to closest. > > Signed-off-by: Lucas Stach > --- > drivers/video/imx-ipu-v3/ipu-di.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/video/imx-ipu-v3/ipu-di.c b/drivers/video/imx-ipu-v3/ipu-di.c > index b6e64fe16a85..5751c678b28e 100644 > --- a/drivers/video/imx-ipu-v3/ipu-di.c > +++ b/drivers/video/imx-ipu-v3/ipu-di.c > @@ -140,10 +140,7 @@ static int ipu_di_clk_calc_div(unsigned long inrate, unsigned long outrate) > int div; > > tmp *= 16; > - > - do_div(tmp, outrate); > - > - div = tmp; > + div = DIV_ROUND_CLOSEST(tmp, outrate); > > if (div < 0x10) > div = 0x10; > -- > 2.19.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox