From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] rtc: ds1307: Set DS1341_BIT_DOSF in the right register
Date: Fri, 16 Nov 2018 08:46:25 +0100 [thread overview]
Message-ID: <20181116074625.lwwouvfii43sroky@pengutronix.de> (raw)
In-Reply-To: <20181115185458.22396-1-andrew.smirnov@gmail.com>
On Thu, Nov 15, 2018 at 10:54:58AM -0800, Andrey Smirnov wrote:
> DS1341_BIT_DOSF is located in DS1337_REG_STATUS, not
> DS1337_REG_CONTROL. Fix the code to reflect that.
>
> Also fix "additionale" -> "additional" typo while at it.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/rtc/rtc-ds1307.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index bb597305e..f1feee468 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -348,10 +348,10 @@ static int ds1307_probe(struct device_d *dev)
> ds1307->regs[1] &= ~DS1341_BIT_ECLK;
>
> /*
> - * Let's set additionale RTC bits to
> + * Let's set additional RTC bits to
> * facilitate maximum power saving.
> */
> - ds1307->regs[0] |= DS1341_BIT_DOSF;
> + ds1307->regs[1] |= DS1341_BIT_DOSF;
> ds1307->regs[0] &= ~DS1341_BIT_EGFIL;
>
> i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-11-16 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:54 Andrey Smirnov
2018-11-16 7:46 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116074625.lwwouvfii43sroky@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox