[PATCH] rtc: ds1307: Set DS1341_BIT_DOSF in the right register

[PATCH] rtc: ds1307: Set DS1341_BIT_DOSF in the right register

[Andrey Smirnov]

DS1341_BIT_DOSF is located in DS1337_REG_STATUS, not
DS1337_REG_CONTROL. Fix the code to reflect that.

Also fix "additionale" -> "additional" typo while at it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/rtc/rtc-ds1307.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index bb597305e..f1feee468 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -348,10 +348,10 @@ static int ds1307_probe(struct device_d *dev)
 			ds1307->regs[1] &= ~DS1341_BIT_ECLK;
 
 			/*
-			 * Let's set additionale RTC bits to
+			 * Let's set additional RTC bits to
 			 * facilitate maximum power saving.
 			 */
-			ds1307->regs[0] |=  DS1341_BIT_DOSF;
+			ds1307->regs[1] |=  DS1341_BIT_DOSF;
 			ds1307->regs[0] &= ~DS1341_BIT_EGFIL;
 
 			i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] rtc: ds1307: Set DS1341_BIT_DOSF in the right register

[Sascha Hauer]

On Thu, Nov 15, 2018 at 10:54:58AM -0800, Andrey Smirnov wrote:
> DS1341_BIT_DOSF is located in DS1337_REG_STATUS, not
> DS1337_REG_CONTROL. Fix the code to reflect that.
> 
> Also fix "additionale" -> "additional" typo while at it.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/rtc/rtc-ds1307.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
> index bb597305e..f1feee468 100644
> --- a/drivers/rtc/rtc-ds1307.c
> +++ b/drivers/rtc/rtc-ds1307.c
> @@ -348,10 +348,10 @@ static int ds1307_probe(struct device_d *dev)
>  			ds1307->regs[1] &= ~DS1341_BIT_ECLK;
>  
>  			/*
> -			 * Let's set additionale RTC bits to
> +			 * Let's set additional RTC bits to
>  			 * facilitate maximum power saving.
>  			 */
> -			ds1307->regs[0] |=  DS1341_BIT_DOSF;
> +			ds1307->regs[1] |=  DS1341_BIT_DOSF;
>  			ds1307->regs[0] &= ~DS1341_BIT_EGFIL;
>  
>  			i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox