mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 08/10] MIPS: port all mach* to multiimage
Date: Wed, 5 Dec 2018 11:50:31 +0300	[thread overview]
Message-ID: <20181205115031.d90c15ad4703eba8f8be818d@gmail.com> (raw)
In-Reply-To: <20181127091935.2992-9-o.rempel@pengutronix.de>

On Tue, 27 Nov 2018 10:19:33 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:


...

> diff --git a/arch/mips/boards/8devices-lima/include/board/board_pbl_start.h b/arch/mips/boards/8devices-lima/lowlevel.S
> similarity index 78%
> rename from arch/mips/boards/8devices-lima/include/board/board_pbl_start.h
> rename to arch/mips/boards/8devices-lima/lowlevel.S
> index e95aa49256..a619747f39 100644
> --- a/arch/mips/boards/8devices-lima/include/board/board_pbl_start.h
> +++ b/arch/mips/boards/8devices-lima/lowlevel.S
> @@ -15,51 +15,39 @@
>   *
>   */
>  
> -#include <mach/debug_ll_ar9344.h>
> +#define BOARD_PBL_START start_8devices_lima
> +
> +#include <mach/debug_ll.h>
> +#include <asm/asm.h>
>  #include <asm/pbl_macros.h>
>  #include <mach/pbl_macros.h>
>  #include <mach/pbl_ll_init_qca4531.h>
>  #include <asm/pbl_nmon.h>
>  
> -	.macro	board_pbl_start
> -	.set	push
> -	.set	noreorder
> +ENTRY_FUNCTION(BOARD_PBL_START)
>  
>  	mips_barebox_10h
>  
> -	debug_ll_ar9344_init
> -
> -	debug_ll_outc '1'
> +	debug_ll_ath79_init
>  

I suppose there is a problem with simultaneous debug_ll support for AR9344 and AR9331 in one binary.
the Kconfig DEBUG_AR9331_UART and DEBUG_AR9344_UART options are mutually exclusive.

Your approach makes it possible to build barebox binary image for AR9331 board with debug_ll code for AR9344
and vice versa.

>  	hornet_mips24k_cp0_setup
> -	debug_ll_outc '2'
>  
>  	/* test if we are in the SRAM */
>  	pbl_blt 0xbd000000 1f t8

"if $pc < 0xbd000000 then jump to 1f"

> -	debug_ll_outc '3'
>  	b skip_flash_test
>  	nop
>  1:
>  	/* test if we are in the flash */
>  	pbl_blt 0xbf000000 skip_pll_ram_config t8

"if $pc < 0xbf000000 then jump to skip_pll_ram_config"


The code checks that $pc is less than 0xbd000000 if true then the code checks
that $pc is less than 0xbf000000. The second check is redundant!



> -	debug_ll_outc '4'
>  skip_flash_test:
>  
>  	pbl_qca4531_ddr2_550_550_init
>  
> -	debug_ll_outc '5'
>  	/* Initialize caches... */
>  	mips_cache_reset
>  
>  	/* ... and enable them */
>  	dcache_enable
>  skip_pll_ram_config:
> -	debug_ll_outc '6'
> -	debug_ll_outnl
> -
> -	mips_nmon
> -
> -	copy_to_link_location	pbl_start
>  
> -	.set	pop
> -	.endm
> +ENTRY_FUNCTION_END(BOARD_PBL_START, qca4531_8devices_lima)

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-12-05  8:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  9:19 [PATCH v3 00/10] MIPS: migrate to multiimage support Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 01/10] images: piggy: use "a" instead of #alloc flag Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 02/10] MIPS: add arch/mips/lib/pbl.lds.S Oleksij Rempel
2018-11-30  7:41   ` Sascha Hauer
2018-11-27  9:19 ` [PATCH v3 03/10] pbl: enable MIPS for PBL_RELOCATABLE Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 04/10] MIPS: start: preserve DTB pointer for later use Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 05/10] MIPS: multiimage: add ENTRY_FUNCTION macros Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 06/10] MIPS: mutliimage: pass devicetree from PBL to the main_entry Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 07/10] MIPS: put main_entry to __bare_init section Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 08/10] MIPS: port all mach* to multiimage Oleksij Rempel
2018-12-05  8:50   ` Antony Pavlov [this message]
2018-12-05 13:58     ` Oleksij Rempel
2018-12-06  9:15       ` Sascha Hauer
2018-12-07  7:09     ` Oleksij Rempel
2018-12-11 11:31       ` Antony Pavlov
2018-12-13  7:10         ` Sascha Hauer
2018-11-27  9:19 ` [PATCH v3 09/10] MIPS: remove HAS_NO_BOARD_HL_CODE support Oleksij Rempel
2018-11-27  9:19 ` [PATCH v3 10/10] MIPS: remove useless board files Oleksij Rempel
2018-11-30  7:46 ` [PATCH v3 00/10] MIPS: migrate to multiimage support Sascha Hauer
2018-11-30  9:41   ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205115031.d90c15ad4703eba8f8be818d@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox