From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/4] of: partition: use NULL instead of never-read argument
Date: Fri, 7 Dec 2018 07:34:33 +0100 [thread overview]
Message-ID: <20181207063433.7623-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20181207063433.7623-1-a.fatoum@pengutronix.de>
len isn't read afterward and of_get_property accepts NULL as third
argument, so do it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/of/partition.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/of/partition.c b/drivers/of/partition.c
index aa6e601b7fe4..257100112108 100644
--- a/drivers/of/partition.c
+++ b/drivers/of/partition.c
@@ -64,9 +64,9 @@ struct cdev *of_parse_partition(struct cdev *cdev, struct device_node *node)
offset = of_read_number(reg, na);
size = of_read_number(reg + na, ns);
- partname = of_get_property(node, "label", &len);
+ partname = of_get_property(node, "label", NULL);
if (!partname)
- partname = of_get_property(node, "name", &len);
+ partname = of_get_property(node, "name", NULL);
if (!partname)
return NULL;
@@ -74,7 +74,7 @@ struct cdev *of_parse_partition(struct cdev *cdev, struct device_node *node)
debug("add partition: %s.%s 0x%08llx 0x%08llx\n", cdev->name, partname, offset, size);
- if (of_get_property(node, "read-only", &len))
+ if (of_get_property(node, "read-only", NULL))
flags = DEVFS_PARTITION_READONLY;
filename = basprintf("%s.%s", cdev->name, partname);
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-07 6:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 6:34 [PATCH 1/4] driver: left shift 1U instead of 1 in bitmask for consistency Ahmad Fatoum
2018-12-07 6:34 ` Ahmad Fatoum [this message]
2018-12-07 6:34 ` [PATCH 3/4] of: partitions: make macro name more generic Ahmad Fatoum
2018-12-07 6:34 ` [PATCH 4/4] of: partition: add no-fixup device tree property Ahmad Fatoum
2018-12-07 7:43 ` Sascha Hauer
2018-12-07 8:38 ` Ahmad Fatoum
2018-12-10 8:39 ` Sascha Hauer
2018-12-14 15:31 ` Ahmad Fatoum
2019-05-23 15:43 ` Ahmad Fatoum
2019-05-24 6:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207063433.7623-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox