mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH] lib/parameter: Fix typecases to match corresponding PARAM_TYPE_*
Date: Thu,  6 Dec 2018 23:32:18 -0800	[thread overview]
Message-ID: <20181207073218.3858-1-andrew.smirnov@gmail.com> (raw)

This change should be a no-op in terms of behavior, but it makes code
less confusing when PARAM_TYPE_* matches the type used in the type
cast.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 lib/parameter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/parameter.c b/lib/parameter.c
index a21b8fa4a..00e9a9ff4 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -343,10 +343,10 @@ static int param_int_set(struct device_d *dev, struct param_d *p, const char *va
 		ret = strtobool(val, pi->value);
 		break;
 	case PARAM_TYPE_INT32:
-		*(uint32_t *)pi->value = simple_strtol(val, NULL, 0);
+		*(int32_t *)pi->value = simple_strtol(val, NULL, 0);
 		break;
 	case PARAM_TYPE_UINT32:
-		*(int32_t *)pi->value = simple_strtoul(val, NULL, 0);
+		*(uint32_t *)pi->value = simple_strtoul(val, NULL, 0);
 		break;
 	case PARAM_TYPE_INT64:
 		*(int64_t *)pi->value = simple_strtoll(val, NULL, 0);
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-12-07  7:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  7:32 Andrey Smirnov [this message]
2018-12-10  8:57 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207073218.3858-1-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox