[PATCH] lib/parameter: Fix typecases to match corresponding PARAM_TYPE_*

[PATCH] lib/parameter: Fix typecases to match corresponding PARAM_TYPE_*

[Andrey Smirnov]

This change should be a no-op in terms of behavior, but it makes code
less confusing when PARAM_TYPE_* matches the type used in the type
cast.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 lib/parameter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/parameter.c b/lib/parameter.c
index a21b8fa4a..00e9a9ff4 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -343,10 +343,10 @@ static int param_int_set(struct device_d *dev, struct param_d *p, const char *va
 		ret = strtobool(val, pi->value);
 		break;
 	case PARAM_TYPE_INT32:
-		*(uint32_t *)pi->value = simple_strtol(val, NULL, 0);
+		*(int32_t *)pi->value = simple_strtol(val, NULL, 0);
 		break;
 	case PARAM_TYPE_UINT32:
-		*(int32_t *)pi->value = simple_strtoul(val, NULL, 0);
+		*(uint32_t *)pi->value = simple_strtoul(val, NULL, 0);
 		break;
 	case PARAM_TYPE_INT64:
 		*(int64_t *)pi->value = simple_strtoll(val, NULL, 0);
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] lib/parameter: Fix typecases to match corresponding PARAM_TYPE_*

[Sascha Hauer]

On Thu, Dec 06, 2018 at 11:32:18PM -0800, Andrey Smirnov wrote:
> This change should be a no-op in terms of behavior, but it makes code
> less confusing when PARAM_TYPE_* matches the type used in the type
> cast.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  lib/parameter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/lib/parameter.c b/lib/parameter.c
> index a21b8fa4a..00e9a9ff4 100644
> --- a/lib/parameter.c
> +++ b/lib/parameter.c
> @@ -343,10 +343,10 @@ static int param_int_set(struct device_d *dev, struct param_d *p, const char *va
>  		ret = strtobool(val, pi->value);
>  		break;
>  	case PARAM_TYPE_INT32:
> -		*(uint32_t *)pi->value = simple_strtol(val, NULL, 0);
> +		*(int32_t *)pi->value = simple_strtol(val, NULL, 0);
>  		break;
>  	case PARAM_TYPE_UINT32:
> -		*(int32_t *)pi->value = simple_strtoul(val, NULL, 0);
> +		*(uint32_t *)pi->value = simple_strtoul(val, NULL, 0);
>  		break;
>  	case PARAM_TYPE_INT64:
>  		*(int64_t *)pi->value = simple_strtoll(val, NULL, 0);
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox