From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: CCMX51: Switch to multiimage support
Date: Fri, 14 Dec 2018 12:30:13 +0100 [thread overview]
Message-ID: <20181214113013.2pk6a2fhtdtd555p@pengutronix.de> (raw)
In-Reply-To: <20181214092716.8150-2-shc_work@mail.ru>
Hi Alexander,
Very nice :) I appreciate lowering the number of defconfigs to build.
Looks mostly fine, two small things:
On Fri, Dec 14, 2018 at 12:27:16PM +0300, Alexander Shiyan wrote:
> +#include <arm/imx51-digi-connectcore-jsk.dts>
> +
> +/ {
> + chosen {
> + stdout-path = &uart1;
> +
> + environment@0 {
> + compatible = "barebox,environment";
> + device-path = &nfc, "partname:env";
> + };
> + };
Some tabs missing here.
> +};
> +
> +&iim {
> + barebox,provide-mac-address = <&fec 1 9>;
> +};
> +
> +&nfc {
> + partition@0 {
> + label = "boot";
> + reg = <0x00000 0x80000>;
> + };
> +
> + partition@1 {
> + label = "env";
> + reg = <0x80000 0x40000>;
> + };
You should add the remaining partitions here aswell and remove
arch/arm/boards/ccxmx51/env/init/mtdparts-nand.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-12-14 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 9:27 [PATCH 1/2] mfd: mc13892: MC13892_POWER_MISC bits revision Alexander Shiyan
2018-12-14 9:27 ` [PATCH 2/2] ARM: CCMX51: Switch to multiimage support Alexander Shiyan
2018-12-14 11:30 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214113013.2pk6a2fhtdtd555p@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox