From: Roland Hieber <rhi@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [PATCH v1 1/3] ARM: rpi: make locally used functions static
Date: Tue, 15 Jan 2019 11:34:21 +0100 [thread overview]
Message-ID: <20190115103423.5233-1-rhi@pengutronix.de> (raw)
These functions are not meant to be a public interface, so they can well
be static. rpi_b_plus_init() was previously declared with a prototype,
which is no longer needed.
This fixes the following build warnings:
.../arch/arm/boards/raspberry-pi/rpi-common.c:124:6: warning: no previous prototype for 'rpi_add_led' [-Wmissing-prototypes]
void rpi_add_led(void)
^~~~~~~~~~~
.../arch/arm/boards/raspberry-pi/rpi-common.c:141:6: warning: no previous prototype for 'rpi_b_init' [-Wmissing-prototypes]
void rpi_b_init(void)
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
arch/arm/boards/raspberry-pi/rpi-common.c | 6 +++---
arch/arm/boards/raspberry-pi/rpi.h | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
index 650b26ce7d..2521bb7aa2 100644
--- a/arch/arm/boards/raspberry-pi/rpi-common.c
+++ b/arch/arm/boards/raspberry-pi/rpi-common.c
@@ -121,7 +121,7 @@ struct gpio_led rpi_leds[] = {
},
};
-void rpi_add_led(void)
+static void rpi_add_led(void)
{
int i;
struct gpio_led *l;
@@ -138,14 +138,14 @@ void rpi_add_led(void)
led_set_trigger(LED_TRIGGER_HEARTBEAT, &l->led);
}
-void rpi_b_init(void)
+static void rpi_b_init(void)
{
rpi_leds[0].gpio = 16;
rpi_leds[0].active_low = 1;
rpi_set_usbethaddr();
}
-void rpi_b_plus_init(void)
+static void rpi_b_plus_init(void)
{
rpi_leds[0].gpio = 47;
rpi_leds[1].gpio = 35;
diff --git a/arch/arm/boards/raspberry-pi/rpi.h b/arch/arm/boards/raspberry-pi/rpi.h
index dd32fee809..b2a0401bd0 100644
--- a/arch/arm/boards/raspberry-pi/rpi.h
+++ b/arch/arm/boards/raspberry-pi/rpi.h
@@ -19,7 +19,6 @@ struct rpi_model {
extern struct gpio_led rpi_leds[];
-void rpi_b_plus_init(void);
void rpi_set_usbethaddr(void);
#endif /* __ARCH_ARM_BOARDS_RPI_H__ */
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-01-15 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 10:34 Roland Hieber [this message]
2019-01-15 10:34 ` [PATCH v1 2/3] mci: bcm2835: " Roland Hieber
2019-01-15 10:34 ` [PATCH v1 3/3] amba: pl011: " Roland Hieber
2019-02-14 13:51 ` Roland Hieber
2019-02-18 8:52 ` Sascha Hauer
2019-02-22 9:23 ` Roland Hieber
2019-01-16 7:52 ` [PATCH v1 1/3] ARM: rpi: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115103423.5233-1-rhi@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox