mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 1/3] ARM: rpi: make locally used functions static
Date: Wed, 16 Jan 2019 08:52:12 +0100	[thread overview]
Message-ID: <20190116075212.rnhenmixnhvfojjc@pengutronix.de> (raw)
In-Reply-To: <20190115103423.5233-1-rhi@pengutronix.de>

On Tue, Jan 15, 2019 at 11:34:21AM +0100, Roland Hieber wrote:
> These functions are not meant to be a public interface, so they can well
> be static. rpi_b_plus_init() was previously declared with a prototype,
> which is no longer needed.
> 
> This fixes the following build warnings:
> 
>     .../arch/arm/boards/raspberry-pi/rpi-common.c:124:6: warning: no previous prototype for 'rpi_add_led' [-Wmissing-prototypes]
>      void rpi_add_led(void)
>           ^~~~~~~~~~~
>     .../arch/arm/boards/raspberry-pi/rpi-common.c:141:6: warning: no previous prototype for 'rpi_b_init' [-Wmissing-prototypes]
>      void rpi_b_init(void)
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2019-01-16  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 10:34 Roland Hieber
2019-01-15 10:34 ` [PATCH v1 2/3] mci: bcm2835: " Roland Hieber
2019-01-15 10:34 ` [PATCH v1 3/3] amba: pl011: " Roland Hieber
2019-02-14 13:51   ` Roland Hieber
2019-02-18  8:52     ` Sascha Hauer
2019-02-22  9:23       ` Roland Hieber
2019-01-16  7:52 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116075212.rnhenmixnhvfojjc@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox