mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>
Subject: [PATCH] ARM: zii-vf610-dev: fix boot sd
Date: Fri, 18 Jan 2019 19:51:08 -0500	[thread overview]
Message-ID: <20190119005108.31747-1-vivien.didelot@gmail.com> (raw)

The 'sd' boot is currently broken on zii-vf610-dev because there are no
mci devices (anymore?), only mmc. There are also no need to check
for the device number since both Rev B and Rev C report their SD card
slot on mmc1.

Note that mmc1.0 is already mounted on /mnt/mmc1.0 once mmc1.probe=1
is typed. It would've been more appropriate to use "ln /mnt/mmc1.0
/mnt/sd", but ln isn't useable with automount since the mountpoint
needs to be already created and ln has no force option. There are
no complains with having two mountpoints for a device, so just blindly
mount the device again.

Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
 .../defaultenv-zii-vf610-dev/init/automount-sd       | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd b/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd
index f44dab34e..442c8a61c 100644
--- a/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd
+++ b/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd
@@ -1,13 +1,3 @@
 #!/bin/sh
 
-if [ x${global.hostname} = xdev-rev-b -o x${global.hostname} = xdev-rev-c ];
-then
-    global sd=0
-else
-    global sd=1
-fi
-
-mkdir -p /mnt/sd
-automount /mnt/sd 'mci${global.sd}.probe=1 && mount /dev/disk${global.sd}.0 /mnt/sd'
-
-exit 0
+automount -d /mnt/sd 'mmc1.probe=1 && mount /dev/mmc1.0 /mnt/sd'
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2019-01-19  0:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19  0:51 Vivien Didelot [this message]
2019-01-19 20:39 ` Andrey Smirnov
2019-01-21 16:55   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190119005108.31747-1-vivien.didelot@gmail.com \
    --to=vivien.didelot@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox