mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: zii-vf610-dev: fix boot sd
Date: Mon, 21 Jan 2019 11:55:30 -0500	[thread overview]
Message-ID: <20190121115530.GC3832@t480s.localdomain> (raw)
In-Reply-To: <CAHQ1cqEaDYyFRo_GJWEEpNOTz57nowhg5rbx+Xj+WptsYbQ7dw@mail.gmail.com>

Hi Andrey,

On Sat, 19 Jan 2019 12:39:45 -0800, Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
> On Fri, Jan 18, 2019 at 4:51 PM Vivien Didelot <vivien.didelot@gmail.com> wrote:
> >
> > The 'sd' boot is currently broken on zii-vf610-dev because there are no
> > mci devices (anymore?), only mmc.
> 
> Yeah, I forgot to update this part in 5f99a8d403 "dts: VFxxx: Add
> aliases for ESDHC controllers", sorry about that!

No worries, I'll add a Fixes tag in v2, if Barebox likes that ;-)

> >  There are also no need to check
> > for the device number since both Rev B and Rev C report their SD card
> > slot on mmc1.
> >
> 
> I think you might be misreading the if condition in that check. What
> it is meant to test is:
> 
> if ((board == VF610 Dev Rev C) || (board == VF610 Dev Rev B)) {
>      SDHCI = SDHCI1
> } else {
>      SDHCI = SDHCI2
> }
> 
> IOW, it is meant to configure development boards to boot from SD card
> (attached to SDHCI1 on both revisions) and from eMMC on other boards
> supported by that build (CFU1, SPU3, SCU4).

OK I got confused because I didn't know that zii-vf610-dev was used by
other platforms, I'll keep the check.

> > Note that mmc1.0 is already mounted on /mnt/mmc1.0 once mmc1.probe=1
> > is typed. It would've been more appropriate to use "ln /mnt/mmc1.0
> > /mnt/sd", but ln isn't useable with automount since the mountpoint
> > needs to be already created and ln has no force option. There are
> > no complains with having two mountpoints for a device, so just blindly
> > mount the device again.
> >
> 
> I think we can still take advantage of default automount path
> (/mnt/mmc1.0), by moving the if check to "boot/sd" and using
> "/mnt/mmc${global.sd}.0/" as a prefix for Linux image and DTB blob.
> This way there would be no need to create a symlink or a second mount
> point and "init/automount-sd" could be dropped completely.

Will do, thank you.


	Vivien

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-01-21 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19  0:51 Vivien Didelot
2019-01-19 20:39 ` Andrey Smirnov
2019-01-21 16:55   ` Vivien Didelot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190121115530.GC3832@t480s.localdomain \
    --to=vivien.didelot@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox