From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glqEU-0003Nv-1S for barebox@lists.infradead.org; Tue, 22 Jan 2019 07:12:28 +0000 Date: Tue, 22 Jan 2019 08:12:24 +0100 From: Sascha Hauer Message-ID: <20190122071224.wcyole4xkshgic3r@pengutronix.de> References: <20190121162926.26051-1-rhi@pengutronix.de> <20190121165616.19170-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190121165616.19170-1-rhi@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] ubi: prevent null pointer reference To: Roland Hieber Cc: Barebox Mailing List On Mon, Jan 21, 2019 at 05:56:16PM +0100, Roland Hieber wrote: > After flashing a bogus UBI image, e.g. when the UBI is bigger than the > available flash size, it can happen that barebox hangs itself with a > stacktrace when the board code or the environment does a ubi_attach() on > boot: > > ERROR: ubi0 error: init_volumes: not enough PEBs, required 7478, available 4024 > unable to handle NULL pointer dereference at address 0x00000204 > pc : [<1fd1eaf2>] lr : [<1fd15aad>] > sp : 1feefd30 ip : 0000000a fp : 1fd5d1d7 > r10: 00001d34 r9 : 00000000 r8 : 1fd5d540 > r7 : 14983148 r6 : 00000006 r5 : ffffffe4 r4 : 14983004 > r3 : 1fd82bfc r2 : 021f0000 r1 : 0000000a r0 : 00000000 > Flags: nzcv IRQs off FIQs off Mode SVC_32 > [<1fd1eaf2>] (ubi_fastmap_destroy_checkmap+0x8/0xa) from [<1fd15aad>] (ubi_read_volume_table+0x4d9/0x71c) > [<1fd15aad>] (ubi_read_volume_table+0x4d9/0x71c) from [<1fd1cbf7>] (ubi_attach+0x157/0x1f8) > [<1fd1cbf7>] (ubi_attach+0x157/0x1f8) from [<1fd16ec3>] (ubi_attach_mtd_dev+0x4a3/0x954) > [...] I just had a look at the kernel and it seems to have the same problem. Anyway, applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox