From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] gen-dtb-s: annotate magic values with their meaning
Date: Mon, 28 Jan 2019 09:59:26 +0100 [thread overview]
Message-ID: <20190128085926.ituxb5236oslorup@pengutronix.de> (raw)
In-Reply-To: <20190125203504.22764-1-u.kleine-koenig@pengutronix.de>
On Fri, Jan 25, 2019 at 09:35:04PM +0100, Uwe Kleine-König wrote:
> This helps understand how the imd stuff works because now
> $(git grep IMD_TYPE_OF_COMPATIBLE) also matches the critical code
> location that creates the imd entry.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> scripts/gen-dtb-s | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/scripts/gen-dtb-s b/scripts/gen-dtb-s
> index 4215461edb3c..2b44ffb361eb 100755
> --- a/scripts/gen-dtb-s
> +++ b/scripts/gen-dtb-s
> @@ -25,7 +25,7 @@ if [ "$imd" = "y" ]; then
> if [ "$compat" != "notfound" ]; then
>
> compatlen=$($FDTGET -t s "$dtb" / compatible | wc -c)
> - le32 0x640c8005
> + le32 0x640c8005 # IMD_TYPE_OF_COMPATIBLE
> le32 $compatlen
> echo ".byte " $compat
> echo ".balign 4"
> @@ -35,7 +35,7 @@ if [ "$imd" = "y" ]; then
>
> if [ "$model" != "notfound" ]; then
> modellen=$($FDTGET -t s "$dtb" / model | wc -c)
> - le32 0x640c8004
> + le32 0x640c8004 # IMD_TYPE_MODEL
> le32 $modellen
> echo ".byte " $model
> echo ".balign 4"
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-28 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:35 Uwe Kleine-König
2019-01-28 8:59 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128085926.ituxb5236oslorup@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox